Create a combinerawtransaction RPC which accepts a json array of hex raw transactions to combine them into one transaction. Signrawtransaction is changed to no longer combine transactions and only accept one transaction at a time.
The tests have been updated to test this. Tests for the signrawtransaction merge have also been removed.
This is part of #10570
582+ UniValue txs = request.params[0].get_array();
583+ std::vector<CMutableTransaction> txVariants(txs.size());
584+
585+ for (unsigned int idx = 0; idx < txs.size(); idx++) {
586+ if (!DecodeHexTx(txVariants[idx], txs[idx].get_str(), true))
587+ throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed for tx " + idx);
586+ if (!DecodeHexTx(txVariants[idx], txs[idx].get_str(), true))
587+ throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed for tx " + idx);
588+ }
589+
590+ if (txVariants.empty())
591+ throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "Missing transactions");
142+ self.sync_all()
143+ self.nodes[0].generate(1)
144+ self.sync_all()
145+
146+ #THIS IS A INCOMPLETE FEATURE
147+ #NODE2 HAS TWO OF THREE KEY AND THE FUNDS SHOULD BE SPENDABLE AND COUNT AT BALANCE CALCULATION
utACK c710eb9
although at least the documentation in the RPC test should probably be corrected
142+ self.sync_all()
143+ self.nodes[0].generate(1)
144+ self.sync_all()
145+
146+ #THIS IS A INCOMPLETE FEATURE
147+ #NODE2 HAS ONE OF TWO KEY AND THE FUNDS SHOULD BE SPENDABLE AND COUNT AT BALANCE CALCULATION
heh thanks… and i think its ok to squash, especially if the old commit can still be found, b/c then a diff btwn old and new can show the differences. it’s the rebase that makes it difficult
utACK f293282
Create a combinerawtransaction RPC which accepts a json array of hex raw
transactions to combine them into one transaction. Signrawtransaction is changed
to no longer combine transactions and only accept one transaction at a time.
582+ UniValue txs = request.params[0].get_array();
583+ std::vector<CMutableTransaction> txVariants(txs.size());
584+
585+ for (unsigned int idx = 0; idx < txs.size(); idx++) {
586+ if (!DecodeHexTx(txVariants[idx], txs[idx].get_str(), true)) {
587+ throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed for tx " + idx);
