Remove includes in .cpp files for things the corresponding .h file already included.
Example case:
addrdb.cpp includes addrdb.h and fs.haddrdb.h includes fs.hThen remove the direct inclusion of fs.h in addrman.cpp and rely on the indirect inclusion of fs.h via the included addrdb.h.
In line with the header include guideline (see #10575).
Candidates for removal found by:
0#!/bin/bash
1
2for H in $(git grep "" -- "*.h" | cut -f1 -d: | uniq); do
3 CPP=${H/%\.h/.cpp}
4 if [[ ! -e $CPP ]]; then
5 continue
6 fi
7 cat "$H" "$CPP" | grep -E "^#include " | sort | uniq -c | \
8 grep " 2 #include" && echo "$CPP" && echo
9done
@luke-jr @danra Then you should argue to change the guidelines in developer-notes.md:
Every .cpp and .h file should #include every header file it directly uses classes, functions or other definitions from, even if those headers are already included indirectly through other headers. One exception is that a .cpp file does not need to re-include the includes already included in its corresponding .h file.
I personally think that rule makes sense, as you can see the .cpp file as the continuation of the corresponding .h file.
@sipa Yes, I’m for changing this rule as it creates an unnecessary dependency of the implementation (.cpp) on the interface (.h). If the interface no longer uses some other include directly, but the implementation still uses that include directly, removing the include from the interface would require adding it to the implementation.
(Note I’m not for having the implementation re-include every include of the interface - only those which it uses directly)
7@@ -8,10 +8,8 @@
8
9 #include <QApplication>
10 #include <QColor>
11-#include <QIcon>
12 #include <QImage>
13 #include <QPalette>
14-#include <QPixmap>
