Slightly overhaul NSI pixmaps #10644

1. 
   jonasschnelli commented at 7:10 PM on June 21, 2017: contributor

   Slightly overhaul the NSI pixmaps. As far as I can see the share/pixmaps/bitcoin*.png|.xmp files are unused (removed in this PR).

   Gitian build will follow.

2. jonasschnelli added the label Windows on Jun 21, 2017
3. 
   jonasschnelli commented at 7:03 AM on June 22, 2017: contributor

   Gitian build: https://bitcoin.jonasschnelli.ch/build/188

   How it looks after this PR: <img width="525" alt="bildschirmfoto 2017-06-22 um 09 02 35" src="https://user-images.githubusercontent.com/178464/27421183-9e9b8cc0-5729-11e7-982a-2d274e1127f2.png"> <img width="525" alt="bildschirmfoto 2017-06-22 um 09 02 45" src="https://user-images.githubusercontent.com/178464/27421184-9e9b9a94-5729-11e7-81cd-3bd4f7905d2d.png">

4. 
   MarcoFalke commented at 7:49 AM on June 22, 2017: member

   Looks like they are used in contrib.

   utACK on the other change.

   git grep xpm ./contrib/
   contrib/debian/bitcoin-qt.install:share/pixmaps/bitcoin32.xpm usr/share/pixmaps
   contrib/debian/bitcoin-qt.install:share/pixmaps/bitcoin16.xpm usr/share/pixmaps
   contrib/rpm/bitcoin.spec:%{_bindir}/convert -resize 16x16 %{buildroot}%{_datadir}/pixmaps/bitcoin256.png %{buildroot}%{_datadir}/pixmaps/bitcoin16.xpm
   contrib/rpm/bitcoin.spec:%{_bindir}/convert -resize 32x32 %{buildroot}%{_datadir}/pixmaps/bitcoin256.png %{buildroot}%{_datadir}/pixmaps/bitcoin32.xpm
   contrib/rpm/bitcoin.spec:%{_bindir}/convert -resize 64x64 %{buildroot}%{_datadir}/pixmaps/bitcoin256.png %{buildroot}%{_datadir}/pixmaps/bitcoin64.xpm
   contrib/rpm/bitcoin.spec:%{_bindir}/convert -resize 128x128 %{buildroot}%{_datadir}/pixmaps/bitcoin256.png %{buildroot}%{_datadir}/pixmaps/bitcoin128.xpm
   contrib/rpm/bitcoin.spec:%{_bindir}/convert %{buildroot}%{_datadir}/pixmaps/bitcoin256.png %{buildroot}%{_datadir}/pixmaps/bitcoin256.xpm
   contrib/rpm/bitcoin.spec:touch %{buildroot}%{_datadir}/pixmaps/*.xpm -r %{SOURCE100}
   contrib/rpm/bitcoin.spec:%attr(0644,root,root) %{_datadir}/pixmaps/*.xpm
   

5. MarcoFalke added this to the milestone 0.15.0 on Jun 22, 2017
6. Slightly overhaul NSI pixmaps 92fb8bd81f
7. jonasschnelli force-pushed on Jun 22, 2017
8. 
   jonasschnelli commented at 7:41 PM on June 22, 2017: contributor

   @MarcoFalke: yes, your right.

   Restored the files (force push amend commit).

9. 
   MarcoFalke commented at 7:52 PM on June 22, 2017: member

   ACK 92fb8bd81fb5e71116f648e6cc149ad27357f2a7

10. 
    laanwj commented at 8:29 AM on June 23, 2017: member

    LGTM, utACK

11. jonasschnelli merged this on Jun 23, 2017
12. jonasschnelli closed this on Jun 23, 2017

    ---

13. jonasschnelli referenced this in commit e2921405df on Jun 23, 2017
14. DrahtBot locked this on Sep 8, 2021

Milestone
0.15.0