Verify binaries from bitcoincore.org and bitcoin.org #10651

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2017-06-verify-coreorg changing 1 files +25 −6

TheBlueMatt commented at 6:05 PM on June 22, 2017: member

In preparation for moving the "official" binary host to bitcoincore.org, use it for verifybinaries (and compare with bitcoin.org).
Verify binaries from bitcoincore.org and bitcoin.org 6270d624cf
laanwj added the label Scripts and tools on Jun 22, 2017
sipa commented at 1:21 AM on June 23, 2017: member

Does this need such hardcoding for those two specific hosts, as opposed to a for HOST in bitcoin.org bitcoincore.org; do loop?
TheBlueMatt commented at 1:32 AM on June 23, 2017: member

I mean that's just as much hard coding since it only downloads the binaries from one of the two (and unless you want to depend on bash for arrays.....).

On June 22, 2017 9:22:05 PM EDT, Pieter Wuille notifications@github.com wrote:

Does this need such hardcoding for those two specific hosts, as opposed to a for HOST in bitcoin.org bitcoincore.org loop?
sipa commented at 1:37 AM on June 23, 2017: member

I see a wget from both?
TheBlueMatt commented at 1:39 AM on June 23, 2017: member

With a very different error message on both :p

On June 22, 2017 9:37:47 PM EDT, Pieter Wuille notifications@github.com wrote:

I see a wget from both?
sipa commented at 1:41 AM on June 23, 2017: member

That seems a silly complication to justify duplicating the logic. Just say "failed to download file X from host Y".
TheBlueMatt commented at 2:14 AM on June 23, 2017: member

Well the first error message correctly highlights that it is most likely the user's fault (bad version string), whereas the second is mostly likely servers acting up. Could go further and attempt to download both in any case, however.

On June 22, 2017 9:41:12 PM EDT, Pieter Wuille notifications@github.com wrote:

That seems a silly complication to justify duplicating the logic. Just say "failed to download file X from host Y".
TheBlueMatt commented at 9:02 PM on June 23, 2017: member

@sipa I added the array-based version at https://github.com/TheBlueMatt/bitcoin/commit/3a60faacd99dc727a43b53ba38966fb1e9cdee1f its more code, and IMO more complex, but if you still prefer it we can do that?
laanwj commented at 9:42 AM on June 24, 2017: member

I mean that's just as much hard coding since it only downloads the binaries from one of the two (and unless you want to depend on bash for arrays.....).

I can't believe we're having a discussion whether to use arrays in 2017. Shellscript is horrible.

(Concept ACK anyhow - I leave all implementation details to you)
TheBlueMatt commented at 5:37 PM on June 24, 2017: member

Heh, well I realized this script is already full of bashism, so I dont really care either way...its more code with the arrays but if we ever plan on adding more mirrors (I dont think so?) then it might be helpful.
jtimon commented at 5:21 AM on June 25, 2017: contributor

Concept ACK
laanwj commented at 12:13 PM on June 28, 2017: member

So, okay, can we make a decision here? Arrays or not? Should we throw a coin?
TheBlueMatt commented at 2:35 PM on June 28, 2017: member

Coin sounds good. My very weak vote is leave it as-is cause I find it less confusing, but dont care strongly either way.
jonasschnelli added this to the milestone 0.15.0 on Jul 7, 2017
sipa commented at 8:18 PM on July 7, 2017: member

If it is this complicated, I retract my suggestion :)
laanwj merged this on Jul 11, 2017
laanwj closed this on Jul 11, 2017
laanwj referenced this in commit cef4b5ccaa on Jul 11, 2017
laanwj commented at 1:26 PM on July 11, 2017: member

Just going to merge this, it's outrageous to keep tools/tests pulls like this open if they simply do correctly what they should do. Cleaning up the code can be done later.
PastaPastaPasta referenced this in commit 1e4ad200da on Jul 6, 2019
PastaPastaPasta referenced this in commit 1d99af1cd6 on Jul 6, 2019
PastaPastaPasta referenced this in commit bedb172fa2 on Jul 8, 2019
PastaPastaPasta referenced this in commit 06d6b53d1a on Jul 9, 2019
PastaPastaPasta referenced this in commit 39cc1b3ce9 on Jul 11, 2019
PastaPastaPasta referenced this in commit d9dcc2c2ce on Jul 13, 2019
PastaPastaPasta referenced this in commit e8394e7dee on Jul 17, 2019
PastaPastaPasta referenced this in commit 7d87aea32a on Jul 17, 2019
PastaPastaPasta referenced this in commit b195cbb5e7 on Jul 18, 2019
barrystyle referenced this in commit 926d376d9b on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Milestone
0.15.0