Trivial: Properly comment about shutdown process in init.cpp file. #10691

pull wraith7 wants to merge 1 commits into bitcoin:master from wraith7:master changing 1 files +5 −6

wraith7 commented at 4:27 PM on June 28, 2017: contributor

No description provided.
jonasschnelli commented at 7:38 PM on June 28, 2017: contributor

ACK d7f8a6f1799076125827749ea61f0abbce201e7d ultra nit: start a sentence with "And then"
jonasschnelli added the label Docs and Output on Jun 28, 2017

in src/init.cpp:108 in d7f8a6f179 outdated

 109 | -// Shutdown() is then
 110 | -// called to clean up database connections, and stop other
 111 | +// signal handler sets fRequestShutdown, which makes main thread's
 112 | +// WaitForShutdown() interrupts the thread group.
 113 | +// And then, WaitForShutdown() makes all other on-going threads
 114 | +// in the thread group join the main therad.

meshcollider commented at 1:27 AM on July 2, 2017:

nit: typo in thread

fanquake commented at 12:40 AM on July 6, 2017: member

Please squash into a single commit.
Properly comment about shutdown process in init.cpp file 581c41157d
wraith7 force-pushed on Jul 6, 2017
wraith7 commented at 11:44 AM on July 6, 2017: contributor

Squashed
MarcoFalke merged this on Sep 12, 2017
MarcoFalke closed this on Sep 12, 2017
MarcoFalke referenced this in commit ce829855cf on Sep 12, 2017
PastaPastaPasta referenced this in commit 934c95259d on Sep 24, 2019
PastaPastaPasta referenced this in commit 374549e053 on Dec 21, 2019
PastaPastaPasta referenced this in commit 7abcade256 on Jan 2, 2020
PastaPastaPasta referenced this in commit 811c8cc4e1 on Jan 4, 2020
PastaPastaPasta referenced this in commit 31ce80da23 on Jan 4, 2020
PastaPastaPasta referenced this in commit b7d1cec3f3 on Jan 10, 2020
PastaPastaPasta referenced this in commit adb3bd6d3b on Jan 10, 2020
PastaPastaPasta referenced this in commit 094298d187 on Jan 10, 2020
PastaPastaPasta referenced this in commit 2dfbe21f79 on Jan 12, 2020
jasonbcox referenced this in commit 0c373ee40a on Oct 7, 2020
ckti referenced this in commit eafe151706 on Mar 28, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels