Trivial: spelling fixes #10705

pull ka7 wants to merge 1 commits into bitcoin:master from ka7:feature/spelling changing 14 files +15 −15
  1. ka7 commented at 5:49 PM on June 29, 2017: none

    patch contains some spelling fixes ( just in comments ) as found by a bot ( http://www.misfix.org, https://github.com/ka7/misspell_fixer ).

  2. jonasschnelli added the label Docs and Output on Jun 29, 2017
  3. jonasschnelli commented at 6:23 PM on June 29, 2017: contributor

    ACK 248d9a2fb1fab3dca595aa988f1fcd895904cf48

  4. paveljanik commented at 6:25 PM on June 29, 2017: contributor

    ax_... upstream, sec256* upstream, leveldb upstream please.

  5. practicalswift commented at 7:39 PM on June 29, 2017: contributor

    Very good finds! Can't believe I haven't found these myself :-)

    The policy is not to fix typos in release notes/change logs, so please skip the changes made in contrib/debian/changelog.

    One of the secp256k1 typos has been reported upstream by me: https://github.com/bitcoin-core/secp256k1/pull/440 :-)

    ACK 248d9a2fb1fab3dca595aa988f1fcd895904cf48 modulo the above + @paveljanik:s comments

  6. practicalswift commented at 8:03 PM on June 29, 2017: contributor

    @ka7 The updated version is better but please also remove the changes made to:

    build-aux/m4/ax_boost_base.m4
    src/leveldb/
    src/secp256k1/
    

    These should be reported upstream instead :-)

  7. practicalswift commented at 9:21 PM on June 29, 2017: contributor

    @ka7 Thanks for a nice first-time contribution!

    I used your misspell_fixer-tool to find 12 typos in the Swift project: https://github.com/apple/swift/pull/10710. That is quite impressive considering that the Swift project has had 218 merged typo fix PRs already. Prior to the run with your tool I believed the Swift repo to be at near zero typos (despite having 1.8 million lines of text in the repo) :-)

    This can be compared to 14 typos in the Bitcoin project which has 400 000 lines of text in the repo (as measured by git grep "" | wc -l).

    To compare:

    • Your tool found one typo per 29 000 lines of text in the Bitcoin repo (400000/14)
    • Your tool found one typo per 150 000 lines of text in the Swift repo (1800000/12)
  8. jnewbery commented at 12:47 PM on June 30, 2017: member
  9. practicalswift commented at 7:22 PM on June 30, 2017: contributor

    ACK 4e285175ff3a2fb1f78ad8216e1c88d3cd594b7b assuming that the current five commits are squashed into one commit :-)

  10. paveljanik commented at 7:20 AM on July 3, 2017: contributor

    ACK after squash

  11. practicalswift commented at 8:45 PM on July 3, 2017: contributor

    @ka7 Could you please include fixing of these typos in this PR as well? :-)

    # a vs an ("an already", "an one-off")
    src/qt/bitcoinstrings.cpp:"Error loading %s: You can't enable HD on a already existing non-HD wallet"),
    src/qt/bitcoinstrings.cpp:QT_TRANSLATE_NOOP("bitcoin-core", "Error loading %s: You can't disable HD on a already existing HD wallet"),
    src/test/netbase_tests.cpp:    // and that a one-off resolves correctly
    
    # duplicate words ("command")
    doc/Doxyfile.in:# popen()) the command command input-file, where command is the value of the
    
  12. jtimon commented at 3:23 AM on July 6, 2017: contributor

    ACK 248d9a2 (but yeah, please, squash)

  13. practicalswift commented at 12:48 PM on July 17, 2017: contributor

    @ka7 Please squash. Do this:

    $ git checkout feature/spelling
    $ git rebase -i HEAD~5
    # replace "pick" with "fixup" for all but the first line (resulting in 1 pick and 4 fixups)
    $ git push -f
    
  14. doc: spelling fixes f42fc1d508
  15. MarcoFalke commented at 10:26 PM on August 15, 2017: member

    Squashed and force pushed: 4e285175f...f42fc1d50

  16. MarcoFalke merged this on Aug 15, 2017
  17. MarcoFalke closed this on Aug 15, 2017

  18. MarcoFalke referenced this in commit d7be7b39fa on Aug 15, 2017
  19. MarcoFalke referenced this in commit 4fb2586661 on Aug 15, 2017
  20. PastaPastaPasta referenced this in commit ba186969e0 on Sep 19, 2019
  21. PastaPastaPasta referenced this in commit 5232613966 on Sep 19, 2019
  22. PastaPastaPasta referenced this in commit 88b83a5e5a on Sep 23, 2019
  23. PastaPastaPasta referenced this in commit 8ec3fa8755 on Sep 23, 2019
  24. PastaPastaPasta referenced this in commit 207cea101a on Sep 24, 2019
  25. PastaPastaPasta referenced this in commit 5c4eff1f20 on Sep 24, 2019
  26. PastaPastaPasta referenced this in commit 07de35a7d4 on Nov 19, 2019
  27. PastaPastaPasta referenced this in commit c2b99183c4 on Nov 19, 2019
  28. PastaPastaPasta referenced this in commit 38edb3b534 on Dec 9, 2019
  29. PastaPastaPasta referenced this in commit 77ddff3578 on Dec 9, 2019
  30. PastaPastaPasta referenced this in commit 17da39791f on Jan 1, 2020
  31. PastaPastaPasta referenced this in commit 3fd3c4f03a on Jan 1, 2020
  32. PastaPastaPasta referenced this in commit 1ba944c55e on Jan 2, 2020
  33. PastaPastaPasta referenced this in commit c9b20f027f on Jan 2, 2020
  34. ckti referenced this in commit 8bafa8b71f on Mar 28, 2021
  35. ckti referenced this in commit be4f007578 on Mar 28, 2021
  36. gades referenced this in commit ee49a8bc86 on Jun 30, 2021
  37. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me