[tests] skip zapwallettxes.py #10802

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:skip_zapwallettxes changing 1 files +5 −1

jnewbery commented at 1:44 PM on July 12, 2017: member

Temporary fix for #10678

zapwallettxes.py doesn't test anything due to a syntax error.

Fixing the syntax error causes the test to fail because of bad interaction between zapwallettxes and persistent mempool. There is a fix for that in #10330

Until #10330 is merged we should disable this test. There's no point in running a test that doesn't actually test anything, and which occasionally causes spurious Travis failures.
[tests] skip zapwallettxes.py 7605add98f
fanquake added the label Tests on Jul 12, 2017
MarcoFalke commented at 10:07 PM on July 16, 2017: member

Tend to NACK. I'd rather have just the fix merged than a total of three pulls. (disable test, fix interaction, enable test)
TheBlueMatt commented at 10:24 PM on July 16, 2017: member

Lets merge #10330!
jnewbery commented at 11:11 PM on July 16, 2017: member

I'd rather have just the fix merged

ok, let's merge it :)
jnewbery closed this on Jul 17, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels