net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 #10825

pull fametrano wants to merge 1 commits into bitcoin:master from fametrano:fametrano-regtestport changing 4 files +14 −2

fametrano commented at 3:17 PM on July 14, 2017: contributor

using the same JSON-RPC default port for both testnet and regtest prevents running both at the same time on the same machine. Since RPCport=P2Pport-1 for both mainnet and testnet, and regtest P2Pport being 18444, 18443 is proposed for regtest RPCport

Documentation has been updated (or created where missing); manpages doc/man/bitcoin*.1 could include information for regtest too
fametrano renamed this:
~~Net set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332~~
NET: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332
on Jul 14, 2017
fanquake added the label P2P on Jul 15, 2017
laanwj added the label Tests on Jul 17, 2017
laanwj commented at 8:16 AM on July 17, 2017: member

Concept ACK. I never understood why testnet and regtest should overlap resources.
sipa commented at 2:29 AM on July 25, 2017: member

Concept ACK
TheBlueMatt commented at 5:17 PM on July 27, 2017: member

Dont think its worth updating tor.md (as regtest nodes shouldn't really be connecting to each other/exposed publicly), but otherwise looks good!
MarcoFalke commented at 9:06 PM on July 27, 2017: member

After fixing the nit, please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

<!-- 82e1bb7
fametrano force-pushed on Aug 4, 2017
changed regtest RPCport to 18443 to avoid conflict with testnet 18332 ce3baa193f
fametrano force-pushed on Aug 4, 2017
fametrano commented at 8:31 AM on August 4, 2017: contributor

removed tor.md change, squashed the rest
laanwj commented at 11:15 PM on September 5, 2017: member

utACK https://github.com/bitcoin/bitcoin/pull/10825/commits/ce3baa193f32078d850945f8c6d5ecb3796adb3b
laanwj renamed this:
~~NET: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332~~
net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332
on Sep 5, 2017
laanwj merged this on Sep 5, 2017
laanwj closed this on Sep 5, 2017
laanwj referenced this in commit 28485c783d on Sep 5, 2017
ariard referenced this in commit ad5247a15a on Aug 22, 2018
ariard referenced this in commit 26f9609daf on Aug 23, 2018
ariard referenced this in commit e8c4a1e369 on Aug 23, 2018
laanwj referenced this in commit 0f34dac67b on Sep 4, 2018
pstratem referenced this in commit 036f8c3ed1 on Sep 6, 2018
jfhk referenced this in commit 7e3ae5a7cc on Nov 14, 2018
HashUnlimited referenced this in commit c00aa02e48 on Nov 26, 2018
kallewoof referenced this in commit e51ed82876 on Oct 4, 2019
Munkybooty referenced this in commit 7457594c90 on Sep 8, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#14013 [doc] Add new regtest ports in man following #10825 ports reattributions