depends: fix fontconfig with newer glibc #10851

theuni commented at 3:39 PM on July 17, 2017: member

Fixes build with newer gcc.

Without this, depends builds fail with gcc7, maybe gcc6.

laanwj added this to the milestone 0.15.0 on Jul 17, 2017

gmaxwell commented at 3:49 PM on July 17, 2017: contributor

Sounds fine to me.

fanquake added the label Build system on Jul 17, 2017

achow101 commented at 7:37 PM on July 17, 2017: member

This fails to build for me with this warning:

/home/andy/bitcoin4/depends/work/build/x86_64-pc-linux-gnu/fontconfig/2.12.4-5ee293e84f5/missing: line 81: gperf: command not found
WARNING: 'gperf' is missing on your system.
         You might have modified some files without having the proper
         tools for further handling them.  Check the 'README' file, it
         often tells you about the needed prerequisites for installing
         this package.  You may also peek at any GNU archive site, in
         case some other package contains this missing 'gperf' program.

It looks like travis failed with the same error

Installing gperf results in this error:

make[4]: Entering directory '/home/andy/bitcoin4/depends/work/build/x86_64-pc-linux-gnu/fontconfig/2.12.4-5ee293e84f5/src'
  CC       fcatomic.lo
  CC       fcblanks.lo
  CC       fccache.lo
  CC       fccfg.lo
  CC       fccharset.lo
  CC       fccompat.lo
  CC       fcdefault.lo
  CC       fcdbg.lo
  CC       fcdir.lo
  CC       fcformat.lo
  CC       fcfreetype.lo
  CC       fcinit.lo
  CC       fcfs.lo
  CC       fclang.lo
  CC       fclist.lo
  CC       fcmatch.lo
  CC       fcmatrix.lo
  CC       fcname.lo
  CC       fcobjs.lo
  CC       fcpat.lo
  CC       fcrange.lo
In file included from fcobjs.c:33:0:
fcobjshash.gperf:28:1: error: conflicting types for ‘FcObjectTypeHash’
 "aspect",FC_ASPECT_OBJECT
 ^~~~~~~~~~~~~~~~
fcobjs.c:28:1: note: previous declaration of ‘FcObjectTypeHash’ was here
 FcObjectTypeHash (register const char *str, register FC_GPERF_SIZE_T len);
 ^~~~~~~~~~~~~~~~
In file included from fcobjs.c:33:0:
fcobjshash.gperf:172:1: error: conflicting types for ‘FcObjectTypeLookup’
fcobjs.c:31:1: note: previous declaration of ‘FcObjectTypeLookup’ was here
 FcObjectTypeLookup (register const char *str, register FC_GPERF_SIZE_T len);
 ^~~~~~~~~~~~~~~~~~
Makefile:642: recipe for target 'fcobjs.lo' failed
make[4]: *** [fcobjs.lo] Error 1

theuni commented at 8:24 PM on July 17, 2017: member

grr! Upstream borked this. I'll just cherry-pick the patch into our current version instead.

laanwj commented at 7:29 AM on July 18, 2017: member

Hehe, that's what you get when you say "fixes build", you get reports of new build problems.

More seriously: this is only used for linking against, right? does raising the fontconfig version raise the minimum fontconfig version requires on the user's system? (by changing the ABI)

theuni commented at 5:11 AM on July 19, 2017: member

@laanwj Yes, this is only for linking against.

That's a good question. We should make sure to check before bumping.

jonasschnelli commented at 7:40 AM on July 19, 2017: contributor

Gitian build errors:

Linux:

/home/ubuntu/build/bitcoin/depends/work/build/i686-pc-linux-gnu/fontconfig/2.12.4-e57b06ea870/missing: line 81: gperf: command not found
WARNING: 'gperf' is missing on your system.

laanwj commented at 11:00 AM on August 1, 2017: member

This seems more trouble than it's worth for 0.15.

Could we maybe backport just the build fix for gcc6/7?

MarcoFalke added this to the milestone 0.14.3 on Aug 1, 2017

MarcoFalke removed this from the milestone 0.15.0 on Aug 1, 2017

MarcoFalke added the label Needs backport on Aug 1, 2017

MarcoFalke added this to the milestone 0.15.0 on Aug 1, 2017

MarcoFalke removed this from the milestone 0.14.3 on Aug 1, 2017

MarcoFalke commented at 11:21 AM on August 1, 2017: member

This should also be backported to 0.14.3.

laanwj commented at 11:33 AM on August 1, 2017: member

Not in the current state at least...

theuni commented at 3:53 PM on August 1, 2017: member

@laanwj Yes, will do that today.

depends: fix fontconfig with newer glibc

See comment for more detail

3498a8d018

theuni force-pushed on Aug 3, 2017

laanwj commented at 9:56 AM on August 3, 2017: member

Travis is a timeout, and probably unrelated, respinning

MarcoFalke commented at 12:03 PM on August 3, 2017: member

Can confirm that 3498a8d018fa02de17e1f9c4cda49f4c7edb3c6c compiles on gcc7.1.1

laanwj renamed this:
~~depends: bump fontconfig to 2.12.4~~
depends: fix fontconfig with newer glibc
on Aug 3, 2017

laanwj commented at 1:06 PM on August 3, 2017: member

Changed the PR title to reflect what the commit does :)

laanwj merged this on Aug 3, 2017

laanwj closed this on Aug 3, 2017

laanwj referenced this in commit e222618a32 on Aug 3, 2017

laanwj removed the label Needs backport on Aug 21, 2017

codablock referenced this in commit 8ee652f4c3 on Jan 30, 2018

CryptoCentric referenced this in commit 3324b818e7 on Feb 28, 2019

CryptoCentric referenced this in commit 805c96fb11 on Mar 2, 2019

MarcoFalke locked this on Sep 8, 2021