libbitcoinconsensus: Add version field to pkg-config info file #10890

pull rohythakur wants to merge 2 commits into bitcoin:master from rohythakur:master changing 1 files +1 −0

rohythakur commented at 4:36 AM on July 21, 2017: none

No description provided.
added version
added version
b21da21791
jonasschnelli added the label Utils and libraries on Jul 21, 2017
in libbitcoinconsensus.pc.in:5 in b21da21791 outdated
```
   1 | @@ -2,6 +2,7 @@ prefix=@prefix@
   2 |  exec_prefix=@exec_prefix@
   3 |  libdir=@libdir@
   4 |  includedir=@includedir@
   5 | +Version=@VERSION@
```
promag commented at 3:03 PM on July 21, 2017:

Usually version is below Description: ....

laanwj commented at 11:53 AM on July 25, 2017:

Why is Version with a capital and the rest with lowercase, it that intentional?

promag commented at 12:04 PM on July 25, 2017:

From other examples yes.
promag commented at 3:03 PM on July 21, 2017: member

Concept ACK.
laanwj commented at 11:54 AM on July 25, 2017: member

Please improve your commit message and PR title, just "add version" does not explain anything.

ping @theuni for review
Update libbitcoinconsensus.pc.in 33234a751c
luke-jr commented at 8:22 AM on July 26, 2017: member

Tested ACK, after commit message is fixed.

Suggest: libbitcoinconsensus: Add version field to pkg-config info file
fanquake renamed this:
~~added version~~
libbitcoinconsensus: Add version field to pkg-config info file
on Jul 28, 2017
fanquake commented at 1:58 PM on July 28, 2017: member

utACK after commit fix, updated the PR title to @luke-jrs suggestion.
theuni commented at 2:24 PM on July 31, 2017: member

I don't think this hurts anything, but adding the bitcoin core version here to query against seems counter to the purpose of the lib.

That said, the change itself is fine.
laanwj commented at 9:52 AM on August 28, 2017: member

but adding the bitcoin core version here to query against seems counter to the purpose of the lib

Yes, I guess ideally it should be versioned based on API, not on bitcoin core version?
laanwj commented at 11:56 AM on October 11, 2017: member

I do think this still needs more discussion, how to version the bitcoin-consensus lib. If no one is interested in that, I'd rather close this instead of just merge something we might regret later.
laanwj closed this on Nov 9, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels