[qt] Fix typo and access key in optionsdialog.ui #10911

pull keystrike wants to merge 1 commits into bitcoin:master from keystrike:master changing 1 files +6 −6
  1. keystrike commented at 4:53 pm on July 22, 2017: contributor
    Tooltip displayed ampersand incorrectly, & should be in text property rather than tooltip so that access key is correctly displayed for accessibility.
  2. fanquake added the label GUI on Jul 22, 2017
  3. benma commented at 7:08 am on July 24, 2017: none
    utACK f066abd0837df5f4d414d6a092e48f334f9bb864
  4. jonasschnelli commented at 9:45 am on July 24, 2017: contributor

    I think the PR description is a little bit misleading because it adds new access keys, right? Are there no overlapping access keys (haven’t checked)?

    Binaries: https://bitcoin.jonasschnelli.ch/build/229

  5. benma commented at 10:09 am on July 24, 2017: none
    As part of my utACK I checked that there is no overlap. Even if there was, it would just cycle through (there is already an instance of that with the two Proxy IP in the network tab).
  6. jonasschnelli commented at 10:11 am on July 24, 2017: contributor
    utACK f066abd0837df5f4d414d6a092e48f334f9bb864 Please update PR description (it’s now part of the git history).
  7. laanwj commented at 12:21 pm on July 24, 2017: member
    utACK
  8. laanwj renamed this:
    Typo in optionsdialog.ui
    [qt] Fix typo and access key in optionsdialog.ui
    on Jul 24, 2017
  9. promag commented at 12:29 pm on July 24, 2017: member
    utACK f066abd. Maybe squash?
  10. in src/qt/forms/optionsdialog.ui:202 in f066abd083 outdated 
    198@@ -199,10 +199,10 @@
199        <item>
200         <widget class="QCheckBox" name="allowIncoming">
201          <property name="toolTip">
202-          <string>Accept connections from outside</string>
203+          <string>Accept connections from outside.</string>
    TheBlueMatt commented at 6:35 pm on July 25, 2017:
    Will this result in a translation string change?
    luke-jr commented at 6:46 am on July 26, 2017:
    Yes, but one that is easy to adjust for.
  11. TheBlueMatt commented at 6:36 pm on July 25, 2017: member
    I assume &amps will not result in translation string changes?
  12. laanwj commented at 6:49 am on July 26, 2017: member

    I assume &amps will not result in translation string changes?

    They do. This should go in after 0.15 branch.

  13. in src/qt/forms/optionsdialog.ui:205 in f066abd083 outdated 
    198@@ -199,10 +199,10 @@
199        <item>
200         <widget class="QCheckBox" name="allowIncoming">
201          <property name="toolTip">
202-          <string>Accept connections from outside</string>
203+          <string>Accept connections from outside.</string>
204          </property>
205          <property name="text">
206-          <string>Allow incoming connections</string>
207+          <string>Allow incomin&amp;g connections</string>
    luke-jr commented at 8:30 am on July 26, 2017:
    This is currently being auto-assigned L. I’m not sure G is logical enough to warrant a change.
    luke-jr commented at 8:37 am on July 26, 2017:
    Suggest leaving this alone until 0.16.
    keystrike commented at 9:46 am on July 26, 2017:
    I don’t see any of these being auto-assigned under Windows or Linux. Perhaps I’m missing something?
  14. in src/qt/forms/optionsdialog.ui:402 in f066abd083 outdated 
    398@@ -399,7 +399,7 @@
399           <string>Connect to the Bitcoin network through a separate SOCKS5 proxy for Tor hidden services.</string>
400          </property>
401          <property name="text">
402-          <string>Use separate SOCKS5 proxy to reach peers via Tor hidden services:</string>
403+          <string>Use separate SOCKS&amp;5 proxy to reach peers via Tor hidden services:</string>
    luke-jr commented at 8:31 am on July 26, 2017:
    This is being auto-assigned S. If we change it, T seems like a more logical choice…
    luke-jr commented at 8:37 am on July 26, 2017:
    Suggest leaving it alone until 0.16.
  15. in src/qt/forms/optionsdialog.ui:513 in f066abd083 outdated 
    506@@ -507,10 +507,10 @@
507        <item>
508         <widget class="QCheckBox" name="hideTrayIcon">
509          <property name="toolTip">
510-          <string>&amp;Hide the icon from the system tray.</string>
511+          <string>Hide the icon from the system tray.</string>
512          </property>
513          <property name="text">
514-          <string>Hide tray icon</string>
515+          <string>&amp;Hide tray icon</string>
    luke-jr commented at 8:38 am on July 26, 2017:
    Redundant with auto-assignment. Suggest leaving it alone until 0.16. (But still fix the tooltip)
  16. in src/qt/forms/optionsdialog.ui:613 in f066abd083 outdated 
    609@@ -610,7 +610,7 @@
610             <string>Third party URLs (e.g. a block explorer) that appear in the transactions tab as context menu items. %s in the URL is replaced by transaction hash. Multiple URLs are separated by vertical bar |.</string>
611            </property>
612            <property name="text">
613-            <string>Third party transaction URLs</string>
614+            <string>&amp;Third party transaction URLs</string>
    luke-jr commented at 8:38 am on July 26, 2017:
    Redundant with auto-assignment. Suggest leaving it alone until 0.16.
  17. luke-jr commented at 8:40 am on July 26, 2017: member

    Since this touches strings, I think we should merge the fixes, but leave the hotkeys alone/unchanged for now.

    Poke me to save affected translations just before merging, so I can restore them after.

  18. jonasschnelli commented at 6:45 pm on August 15, 2017: contributor
    @keystrike: can you squash these two commits?
  19. MarcoFalke commented at 3:54 pm on September 7, 2017: member
    @keystrike Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
  20. Typo in optionsdialog.ui 
    Tooltip displayed ampersand incorrectly, &amp; should be in text.
    d2be7b25b5
  21. jonasschnelli force-pushed on Sep 7, 2017
  22. jonasschnelli merged this on Sep 7, 2017
  23. jonasschnelli closed this on Sep 7, 2017
  24. jonasschnelli referenced this in commit 9c8f3655cc on Sep 7, 2017
  25. jonasschnelli commented at 4:02 pm on September 7, 2017: contributor
    squashed by maintainer due to lack of response.
  26. PastaPastaPasta referenced this in commit baf09466db on Sep 23, 2019
  27. PastaPastaPasta referenced this in commit e5df2716f1 on Sep 24, 2019
  28. PastaPastaPasta referenced this in commit 0363f86c9b on Nov 19, 2019
  29. PastaPastaPasta referenced this in commit 2ea1cf706b on Nov 21, 2019
  30. PastaPastaPasta referenced this in commit e9a3792516 on Dec 9, 2019
  31. PastaPastaPasta referenced this in commit 8371319740 on Jan 1, 2020
  32. PastaPastaPasta referenced this in commit b03550ea5f on Jan 2, 2020
  33. PastaPastaPasta referenced this in commit 516a3241d7 on Jan 2, 2020
  34. PastaPastaPasta referenced this in commit 85933fd38a on Jan 2, 2020
  35. PastaPastaPasta referenced this in commit 5655985fec on Jan 2, 2020
  36. PastaPastaPasta referenced this in commit 0df31ee7eb on Jan 2, 2020
  37. PastaPastaPasta referenced this in commit 1d2cd24824 on Jan 3, 2020
  38. ckti referenced this in commit d1c7672dfb on Mar 28, 2021
  39. DrahtBot locked this on Sep 8, 2021


keystrike benma jonasschnelli laanwj promag TheBlueMatt luke-jr MarcoFalke

Labels
GUI

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-10 06:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me