Add chainwork to getchaintxstats #10946

pull sipa wants to merge 1 commits into bitcoin:master from sipa:20170727_chainworkstats changing 1 files +1 −0

sipa commented at 5:18 AM on July 28, 2017: member

This makes it easier to create and verify the nMinimumChainWork data in chain parameters.
Add chainwork to getchaintxstats e452a37f67
gmaxwell commented at 5:31 AM on July 28, 2017: contributor

Hm? getblockchaininfo gives it to you, and this is what the readme tells you to use.
fanquake added the label RPC/REST/ZMQ on Jul 28, 2017
sipa commented at 5:34 AM on July 28, 2017: member

It only gives it you for the tip. getchaintxstats works for any block.
promag commented at 10:33 PM on July 28, 2017: member

Can you add the new field in the functional test in test/functional/blockchain.py?
jnewbery commented at 11:34 PM on July 29, 2017: member

What's the reason for wanting chainwork for any arbitrary block? Are you expecting to use nMinimumChainWork and defaultAssumeValid from the same block? Or is it so you can verify you have the exact same value as someone else who's run the release process?
sipa commented at 11:53 PM on July 29, 2017: member

@jnewbery Yes, ability to repeatably come up with the same numbers, even if the exact value doesn't matter.

This probably belongs more in getblockheader than in getchaintxstats, as it's not really a statistic about transactions. Closing.
sipa closed this on Jul 29, 2017
achow101 commented at 12:05 AM on July 30, 2017: member

getblockheader already includes the chainwork for a block.
sipa commented at 12:15 AM on July 30, 2017: member

Oops, totally unnecessary in that case.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels