[Wallet] Bare segwit scriptPubKey should not considered change by the wallet #10947

1. 
   NicolasDorier commented at 9:26 am on July 28, 2017: contributor

   As the test describe, segwit scriptPubKey are considered as change. It means that if you import the scriptPubKey, then send money to it, and call listtransactions, you will not see it. (contrary to p2sh scriptPubKey)

   This PR makes it possible to use watchonly on segwit scriptPubKey.

2. fanquake added the label Wallet on Jul 28, 2017
3. 
   NicolasDorier commented at 9:30 am on July 28, 2017: contributor

   Not working after restart…. working on it.
4. [RPC] Wallet: Reproduce difference of behavior between p2sh and p2wsh a17a74708d
5. [Wallet] TxDestination for CWitKeyID and CWitScriptID b8c82ae455
6. NicolasDorier force-pushed on Jul 28, 2017
7. 
   NicolasDorier commented at 10:11 am on July 28, 2017: contributor

   For this PR to work, I would need to save CWitKeyID and CWitKScriptID from the mapAddressBook into CWalletDB. Problem is, now CBitcoinAddress is used to serialized TxDestination into string. This mean that CBitcoinAddress would need to support Bech32 or completely removed into another system (a new visitor?).

   I think this PR will become useful for 0.15.1, so I am not closing it.

8. NicolasDorier renamed this:
   [Wallet] Bare segwit scriptPubKey are not considered change by the wallet
   [Wallet] Bare segwit scriptPubKey should not considered change by the wallet
   on Jul 28, 2017
9. 
   ryanofsky commented at 8:48 pm on January 9, 2018: member

   It seems like the code changes here are superceded by #11167, but maybe the new python test is useful to keep. Is this correct?
10. 
    NicolasDorier commented at 7:21 pm on January 14, 2018: contributor

    @ryanofsky the test have been included by sipa in another PR (I don’t remember when though).
11. 
    NicolasDorier commented at 1:54 am on January 15, 2018: contributor

    Closing this sipa already fixed it and included the test.
12. NicolasDorier closed this on Jan 15, 2018

    ---

13. 
    NicolasDorier commented at 1:56 am on January 15, 2018: contributor

    Was merged on https://github.com/bitcoin/bitcoin/commit/06eaca63139ac02abf82b0245b42493c9b383905
14. DrahtBot locked this on Sep 8, 2021

Contributors
NicolasDorier ryanofsky

Labels
Wallet