-salvagewallet seems to be causing more issues than it fixes, it should be removed #10991

1. 
   achow101 commented at 2:57 am on August 5, 2017: member

   I have noticed that -salvagewallet seems to be actually causing more issues than it actually fixes.

   Below is a list of things I have found so far that are problematic:

   • Default key is not passed through causing problems with encrypted wallets and -usehd=1 (fixed in #10952)
   • Wallet version number is not preserved, so salvaged wallets become version 10500, which could have unexpected behavior with optional features such as HD and HD chain split
   • salvaging seems to be skipping keys for some unknown reason. There is no given error, it just skips keys
2. 
   jnewbery commented at 5:24 am on August 5, 2017: member

   Good discussion of the issues with salvagewallet here: #10540

   At the very least, salvagewallet should be in a tool outside of bitcoind. I’m hoping we’ll get that done before 0.16. Would you be interested in working on that with me?

3. 
   TheBlueMatt commented at 9:01 pm on August 6, 2017: contributor

   Hmm, can we add an extra warning for when salvage reads an HD key in 15? The others seen to be just “salvage is really not so good and sould be an external tool”, but that seems very likely to cause issues.

   On August 4, 2017 10:57:07 PM EDT, Andrew Chow notifications@github.com wrote:

   I have noticed that -salvagewallet seems to be actually causing more issues than it actually fixes.

   Below is a list of things I have found so far that are problematic:

   • Default key is not passed through causing problems with encrypted wallets and -usehd=1 (fixed in #10952)
   • Wallet version number is not preserved, so salvaged wallets become version 10500, which could have unexpected behavior with optional features such as HD and HD chain split
   • salvaging seems to be skipping keys for some unknown reason. There is no given error, it just skips keys

   – You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/bitcoin/bitcoin/issues/10991

4. jonasschnelli added the label Wallet on Aug 8, 2017
5. 
   Sjors commented at 10:36 am on May 18, 2020: member

   #18918 moves salvagewallet into the wallet tool
6. 
   adamjonas commented at 0:01 am on July 26, 2022: member

   -salvagewallet was removed in #18918
7. adamjonas closed this on Jul 26, 2022

   ---

8. bitcoin locked this on Jul 26, 2023

Contributors
achow101 jnewbery TheBlueMatt Sjors adamjonas

Labels
Wallet