Return service bits 6 and 8 on Aug 1, 2018 #10993

1. 
   TheBlueMatt commented at 2:36 PM on August 5, 2017: member

   #10982 started disconnecting service bits 6 and 8 until aug 1, 2018, the code to do so should be removed on or after that date.

2. 
   jgarzik commented at 2:56 PM on August 5, 2017: contributor

   ~NAK, this code causes compatible clients to prematurely split the network.~

   Edited: PR #10982 will split the network due to bit-7 inclusion. This issue does not refer to bit-7.

   It is noted that disconnecting service bits should only be enabled after peers have started banning each other on the network, thus proving the safety of service bit disconnect.

3. jonasschnelli added the label P2P on Aug 7, 2017
4. 
   MarcoFalke commented at 9:39 PM on August 7, 2017: member

   Commits to be reverted after that date:

   • 1de73f4e19fe789abb636afdb48a165a6fd31009
   • 5e35cd9
5. MarcoFalke added this to the milestone Future on Aug 7, 2017
6. MarcoFalke closed this on Nov 8, 2017

   ---

7. 
   meshcollider commented at 7:33 PM on November 8, 2017: contributor

   c.f. https://github.com/bitcoin/bitcoin/pull/11637

8. MarcoFalke reopened this on Dec 6, 2017

   ---

9. MarcoFalke removed this from the milestone Future on May 3, 2018
10. MarcoFalke added this to the milestone 0.17.0 on May 3, 2018
11. laanwj closed this on Jul 20, 2018

    ---

12. laanwj referenced this in commit c575260f80 on Jul 20, 2018
13. PastaPastaPasta referenced this in commit 29ffc70771 on Dec 21, 2020
14. PastaPastaPasta referenced this in commit b4c35cac0f on Jan 11, 2021
15. PastaPastaPasta referenced this in commit 72e13944fd on Jan 11, 2021
16. PastaPastaPasta referenced this in commit 49a9d02c46 on Feb 2, 2021
17. DrahtBot locked this on Sep 8, 2021

Contributors

TheBlueMattjgarzikMarcoFalkemeshcollider

Milestone
0.17.0