Add option to avoid warning on certain network upgrades #10994

1. 
   ajtowns commented at 4:58 PM on August 5, 2017: member

   The "-vbignore=bit:start:end" option can be used to prevent bitcoin from alerting the user of known but uninteresting proposed upgrades that are being signalled via the version field.

   This hopefully provides the feature requested in issue #8266, allow version bits to have an "ignore button". It requires specifying start and end times rather than a final block height, which should map better to BIP 9 implementations. It also allows multiple deployments on a single bit to be ignored independently -- if the bit is used in between any deployments, it will still generate warnings.

   This setting will also avoid the bit from triggering the "Unknown block versions being mined" warning during the set period.

2. 
   promag commented at 1:14 AM on August 15, 2017: member

   Missing update to help message.

3. laanwj added the label P2P on Oct 4, 2017
4. laanwj requested review from gmaxwell on Oct 4, 2017
5. 
   laanwj commented at 1:41 PM on October 4, 2017: member

   Concept ACK

   Ping @gmaxwell which requested this.

6. ajtowns force-pushed on Oct 10, 2017
7. ajtowns force-pushed on Oct 10, 2017
8. 
   ajtowns commented at 7:22 AM on October 10, 2017: member

   Rebased against master; updated help text; moved structure definition to versionbits.h; use emplace_back instead of push_back.

   Added additional commit that removes the BIP109/bit 28 warning on testnet by default, without the user needing to specify the parameter.

9. 
   laanwj commented at 4:59 PM on November 16, 2017: member

   It looks like interest in this got lost a bit due to recent drama, because it is not sure how feasible BIP9 still is in the first place.

   But anyhow ping @gmaxwell (again, sorry).

10. ajtowns force-pushed on Nov 18, 2017
11. 
    ajtowns commented at 10:42 AM on November 18, 2017: member

    Rebased; use an enum class instead of a bool for use_ignorebits argument to ComputeBlockVersion.

    FWIW, I think version bits would still be useful for BIP8 or BIP148/BIP91-style UASF's; full node users can require miners to signal support (or to not signal support if they want to opt-out of a change) so as to allow two potential chains to be easily distinguished by SPV clients.

12. Add option to avoid warning on certain network upgrades

    The "-vbignore=bit:start:end" option can be used to prevent bitcoin
    from alerting the user of known but uninteresting proposed upgrades
    that are being signalled via the version field.

    5e3600ebf7
13. Ignore signalling for irrelevant forks

    This provides the ability to specify irrelevant versionbit signalling
    as part of the chain parameters, in order to avoid issuing warnings for
    possible consensus changes. The "-novbignoredefaults" option can be used
    to disable this behaviour.
    
    This patch ignores signalling for BIP109 via bit 28 in 2016/2017 on
    testnet via this mechanism.

    98b8d66c30
14. ajtowns force-pushed on Nov 21, 2017
15. 
    ajtowns commented at 6:21 PM on March 6, 2018: member

    Going to close this until there's some clarity on what method might get used for soft-forks in future (bip 9, bip 8, something else)...

16. ajtowns closed this on Mar 6, 2018

    ---

17. MarcoFalke locked this on Sep 8, 2021

Review Requested
gmaxwell