[qa] Fix block message processing error in sendheaders.py #11032

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:2017-08-sendheaders changing 1 files +0 −3

sdaftuar commented at 3:50 PM on August 11, 2017: member

Introduced in #10169 @jnewbery
MarcoFalke commented at 4:02 PM on August 11, 2017: member

utACK 38bb21bb409d4da4ffe6f81f9b060a75334d6fb6
MarcoFalke added the label Tests on Aug 11, 2017
jnewbery commented at 6:05 PM on August 11, 2017: member

good catch!

The last_message["block"] variable isn't actually used at all in this test (and last_block wasn't used before my refactor which introduced this bug), so we can actually just remove the on_block() method override entirely.
[qa] Fix block message processing error in sendheaders.py f1bf31186c
sdaftuar force-pushed on Aug 12, 2017
sdaftuar commented at 1:36 AM on August 12, 2017: member

@jnewbery Done.
promag commented at 1:50 AM on August 12, 2017: member

utACK f1bf311.
fanquake commented at 2:09 AM on August 12, 2017: member

utACK f1bf311
MarcoFalke merged this on Aug 12, 2017
MarcoFalke closed this on Aug 12, 2017
MarcoFalke referenced this in commit aeb3175627 on Aug 12, 2017
PastaPastaPasta referenced this in commit de30da3a55 on Aug 6, 2019
PastaPastaPasta referenced this in commit b48a5a2d8a on Aug 6, 2019
PastaPastaPasta referenced this in commit 034b6f5124 on Aug 6, 2019
PastaPastaPasta referenced this in commit ba1f724983 on Aug 7, 2019
PastaPastaPasta referenced this in commit 6e26b48aee on Aug 8, 2019
PastaPastaPasta referenced this in commit 7f3d3deda7 on Aug 12, 2019
barrystyle referenced this in commit 1260977d97 on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10169 [tests] Remove func test code duplication