[wallet] Keypool topup cleanups #11044

1. 
   jnewbery commented at 5:40 PM on August 14, 2017: member

   A couple of minor cleanups suggested by @ryanofsky here: #11022#pullrequestreview-55598940

   Does not affect functionality. Not required for v0.15.

2. MarcoFalke added the label Docs and Output on Aug 14, 2017
3. MarcoFalke added the label Wallet on Aug 14, 2017
4. MarcoFalke added this to the milestone 0.15.0 on Aug 14, 2017
5. MarcoFalke added the label Needs backport on Aug 14, 2017
6. 
   MarcoFalke commented at 6:01 PM on August 14, 2017: member

   Tagged for backport if there is an rc2, as this fixes a confusing warning when building from source.

7. 
   paveljanik commented at 6:10 PM on August 14, 2017: contributor

   Warnings removed.

   ACK https://github.com/bitcoin/bitcoin/pull/11044/commits/61aa92d9a854677cafefb15117c3d83d6bab6af6

8. 
   jonasschnelli commented at 8:58 AM on August 15, 2017: contributor

   utACK 61aa92d9a854677cafefb15117c3d83d6bab6af6

9. 
   promag commented at 3:02 PM on August 16, 2017: member

   Log message is consistent with others related.

   Nit, I would reword 063aab4 to Remove unused CWallet::HasUnusedKeys since it doesn't really revert c25d90f, but keep the body.

   ACK 61aa92d.

10. 
    sipa commented at 6:19 PM on August 16, 2017: member

    utACK 61aa92d9a854677cafefb15117c3d83d6bab6af6

11. [wallet] Remove keypool_topup_cleanups

    Unused function. Mostly reverts c25d90f125d69e33688288eff439eb7be75012e9
    
    c25d90f... was merged as part of PR 11022 but is not required.

    1221f60c94
12. [wallet] Add logging to MarkReserveKeysAsUsed 67ceff4039
13. jnewbery force-pushed on Aug 16, 2017
14. 
    jnewbery commented at 9:24 PM on August 16, 2017: member

    Thanks @promag . I've changed the commit message, but contents of the commit are the same. Check that https://github.com/bitcoin/bitcoin/commit/61aa92d9a854677cafefb15117c3d83d6bab6af6 == 67ceff4039ae038ae16f06128f868a2e8395b59a

15. in src/wallet/wallet.cpp:3662 in 67ceff4039

    3658 | @@ -3659,15 +3659,11 @@ void CWallet::MarkReserveKeysAsUsed(int64_t keypool_id)
    3659 |              m_pool_key_to_index.erase(keypool.vchPubKey.GetID());
    3660 |          }
    3661 |          walletdb.ErasePool(index);
    3662 | +        LogPrintf("keypool index %d removed\n", index);
    

    ---

    ---

    

    laanwj commented at 2:37 PM on August 18, 2017:

    I'd prefer to put this in the wallet debug category - it's just an info message, and not very useful for most end-users I guess? (it could even be vaguely worrying if you don't know what it's about)

    ---

    

    promag commented at 2:51 PM on August 18, 2017:

    Followup PR to change for all?

    ---

    

    jnewbery commented at 2:53 PM on August 18, 2017:

    This matches the existing 'keypool keep' logs, which are not wallet debug category.

    This PR already has a bunch of ACKs and it's wanted for rc2, so I'd rather not change this now. I'll happily open a PR to make this (and other wallet logs) wallet debug category.

    ---

    

    laanwj commented at 3:23 PM on August 18, 2017:

    Ok...

16. 
    promag commented at 2:51 PM on August 18, 2017: member

    ACK 67ceff4.

17. laanwj merged this on Aug 18, 2017
18. laanwj closed this on Aug 18, 2017

    ---

19. laanwj referenced this in commit 0e5b7486cb on Aug 18, 2017
20. laanwj referenced this in commit 4ef8374559 on Aug 21, 2017
21. laanwj referenced this in commit 6ab120cc6c on Aug 21, 2017
22. laanwj removed the label Needs backport on Aug 21, 2017
23. jnewbery deleted the branch on May 23, 2018
24. jasonbcox referenced this in commit 08e2c02735 on Sep 13, 2019
25. PastaPastaPasta referenced this in commit 6946848e02 on Sep 19, 2019
26. PastaPastaPasta referenced this in commit 1d1e735610 on Sep 20, 2019
27. PastaPastaPasta referenced this in commit 02328ae966 on Sep 20, 2019
28. barrystyle referenced this in commit 4e643e4d4a on Jan 22, 2020
29. MarcoFalke locked this on Sep 8, 2021

Contributors

jnewberyMarcoFalkepaveljanikjonasschnellipromagsipalaanwj

Milestone
0.15.0