Replace boost sleep_for with C++11 equivalent #11046

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2017/08/boost_sleep_for changing 3 files +7 −74

jonasschnelli commented at 6:31 PM on August 14, 2017: contributor

Replaces boost::thread::sleep_for with C++ equivalent. Removes ugly boost sleep_for version check and compatibility control structure.

Not meant for 0.15.
Replace boost sleep_for with C++11 equivalent 2a59a5745f
jonasschnelli added the label Refactoring on Aug 14, 2017
laanwj commented at 6:37 PM on August 14, 2017: member

Nice. The difference is that this one is not interruptible. Not sure if that still makes a difference, though. @theuni?
practicalswift commented at 8:03 PM on August 14, 2017: contributor

Very nice! Concept strong ACK :-)
XingZheZ commented at 12:50 PM on August 16, 2017: none

Great!
XingZheZ commented at 12:51 PM on August 16, 2017: none

可能还有细节需要考虑。
theuni commented at 4:02 AM on August 17, 2017: member

Yes, we can't do this just yet. This would make MilliSleep non-interruptible, meaning that a few threads (see upnp for an easy example) would hang around for several minutes before dying.

Due to the renewed interest (see #10923) as well, I'll finish up the std thread/mutex/condvar conversion asap so that we can proceed with changes like these. There aren't many left now.
fanquake added this to the "In progress" column in a project

in src/test/scheduler_tests.cpp:14 in 2a59a5745f

  10 | @@ -11,6 +11,9 @@
  11 |  #include <boost/thread.hpp>
  12 |  #include <boost/test/unit_test.hpp>
  13 |  
  14 | +#include <chrono>

promag commented at 10:35 PM on September 4, 2017:

Remove, it's included in thread header.

in src/test/scheduler_tests.cpp:15 in 2a59a5745f

  10 | @@ -11,6 +11,9 @@
  11 |  #include <boost/thread.hpp>
  12 |  #include <boost/test/unit_test.hpp>
  13 |  
  14 | +#include <chrono>
  15 | +#include <thread>

promag commented at 10:35 PM on September 4, 2017:

Include before boost headers.

in src/utiltime.cpp:13 in 2a59a5745f

   9 | @@ -10,9 +10,10 @@
  10 |  #include "utiltime.h"
  11 |  
  12 |  #include <atomic>
  13 | +#include <chrono>

promag commented at 10:35 PM on September 4, 2017:

Remove.

laanwj commented at 1:37 PM on October 4, 2017: member

Closing for now, as we can't do this yet. Please rebase and reopen once the dependencies went in.
laanwj closed this on Oct 4, 2017
fanquake moved this from the "In progress" to the "Later" column in a project

MarcoFalke commented at 6:58 PM on February 21, 2020: member

After f26866b9caf9ff27d129c703f51b8c2922000243, this should now be possible to do. See here: #16117
MarcoFalke moved this from the "Later" to the "Done" column in a project

DrahtBot locked this on Feb 15, 2022

Contributors

Labels