disable jni in builds #11056

1. 
   instagibbs commented at 5:29 PM on August 15, 2017: member

   Suggested by @theuni

   Unneeded and was causing travis issues downstream.

2. disable jni in builds 844b73e486
3. 
   theuni commented at 5:38 PM on August 15, 2017: member

   utACK. @instagibbs had an unrelated build failure due to (auto) jni detection in libsecp256k1. Regardless of that problem (which should be addressed), we should be deterministic in the downstream features we enable/build.

4. 
   laanwj commented at 6:08 PM on August 15, 2017: member

   What is jni and how would it possibly have any influence on us?

5. laanwj added the label Utils and libraries on Aug 15, 2017
6. 
   sipa commented at 6:11 PM on August 15, 2017: member

   libsecp256k1 has (optional) JNI bindings

7. 
   jonasschnelli commented at 6:25 PM on August 15, 2017: contributor

   utACK 844b73e486ca146f3f9f3060e878814752c25fd5 though I think the libsecp256k1 JNI (java native interface) default should not be auto ("no" as default makes more sense IMO).

8. 
   laanwj commented at 6:28 PM on August 15, 2017: member

   If the answer is that it doesn't affect us in any way, then it should be disabled, I agree. If anything it's a waste of resources building.

   utACK.

9. 
   fanquake commented at 9:13 PM on August 15, 2017: member

   ACK https://github.com/bitcoin/bitcoin/commit/844b73e486ca146f3f9f3060e878814752c25fd5

10. laanwj added the label Needs backport on Aug 16, 2017
11. laanwj added this to the milestone 0.15.0 on Aug 16, 2017
12. laanwj merged this on Aug 16, 2017
13. laanwj closed this on Aug 16, 2017

    ---

14. laanwj referenced this in commit d451d0bcf1 on Aug 16, 2017
15. laanwj referenced this in commit cbdd338a75 on Aug 21, 2017
16. laanwj removed the label Needs backport on Aug 21, 2017
17. sickpig referenced this in commit 64d4d0ca1c on Oct 18, 2017
18. sickpig referenced this in commit 7a61f2982c on Oct 19, 2017
19. gmaxwell referenced this in commit b549d3d5f7 on Feb 6, 2018
20. PastaPastaPasta referenced this in commit 8ed0d522fb on Aug 2, 2019
21. PastaPastaPasta referenced this in commit f2296a7a1b on Aug 6, 2019
22. barrystyle referenced this in commit e456a92217 on Jan 22, 2020
23. DrahtBot locked this on Sep 8, 2021

Milestone
0.15.0