Remove dead store in ecdsa_signature_parse_der_lax. #11073

pull BitonicEelis wants to merge 1 commits into bitcoin:master from BitonicEelis:deadstore changing 1 files +0 −1

BitonicEelis commented at 12:29 PM on August 17, 2017: contributor

This was one of the issues found by Clang's static analyzer (#9573).

Remove dead store in ecdsa_signature_parse_der_lax.

This was one of the issues found by Clang's static analyzer (#9573).

bfebc0b807

laanwj commented at 12:37 PM on August 17, 2017: member

Yes, that assignment is unnecessary. pos is a local variable and not used after.
laanwj added the label Refactoring on Aug 17, 2017
practicalswift commented at 2:34 PM on August 17, 2017: contributor

utACK bfebc0b8071beb82e20afa2b5d751a5c6e725329 @BitonicEelis Nice first-time contribution! 👍 Please keep it coming! :-)
BitonicEelis commented at 2:37 PM on August 17, 2017: contributor

@practicalswift Thanks! I plan to. :)
promag commented at 12:29 AM on August 18, 2017: member

utACK bfebc0b.
laanwj commented at 6:32 AM on August 24, 2017: member

@sipa can you take a look here just to be sure that not using pos after the increase doesn't indicate a bug?
fanquake requested review from sipa on Aug 28, 2017
laanwj commented at 10:15 AM on October 11, 2017: member

Ping @sipa
sipa commented at 1:33 AM on October 12, 2017: member

utACK bfebc0b8071beb82e20afa2b5d751a5c6e725329
sipa approved
laanwj merged this on Oct 12, 2017
laanwj closed this on Oct 12, 2017
laanwj referenced this in commit 3bb77ebee6 on Oct 12, 2017
PastaPastaPasta referenced this in commit 43d80da239 on Dec 22, 2019
PastaPastaPasta referenced this in commit 5872a6c85f on Jan 2, 2020
PastaPastaPasta referenced this in commit 352cfd8398 on Jan 4, 2020
PastaPastaPasta referenced this in commit 1b827e7fbe on Jan 12, 2020
PastaPastaPasta referenced this in commit e37f097d4b on Jan 12, 2020
PastaPastaPasta referenced this in commit 782c89cf03 on Jan 12, 2020
PastaPastaPasta referenced this in commit b81ddd2eff on Jan 12, 2020
PastaPastaPasta referenced this in commit b7b4bc1bc3 on Jan 12, 2020
PastaPastaPasta referenced this in commit f836d16d30 on Jan 12, 2020
PastaPastaPasta referenced this in commit df109ec118 on Jan 12, 2020
fanquake referenced this in commit f00d6575ca on Jun 29, 2020
jasonbcox referenced this in commit 1f985e5a3b on Sep 27, 2020
deadalnix referenced this in commit 7fe66ef9d1 on Sep 28, 2020
ckti referenced this in commit f550de4fa9 on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9573 6696b46: Clang Static Analyzer Report