Document assumptions that are being made to avoid NULL pointer dereferences #11132

1843 | @@ -1843,6 +1844,7 @@ static bool ConnectBlock(const CBlock& block, CValidationState& state, CBlockInd
1844 |          if (!pblocktree->WriteTxIndex(vPos))
1845 |              return AbortNode(state, "Failed to write transaction index");
1846 |  
1847 | +    assert(pindex->phashBlock && "pindex->phashBlock != nullptr assumed.");

sipa commented at 4:18 PM on August 25, 2017:

Repeating the condition in a message is not very useful.

1703 | @@ -1704,6 +1704,7 @@ static bool ConnectBlock(const CBlock& block, CValidationState& state, CBlockInd
1704 |      // before the first had been spent.  Since those coinbases are sufficiently buried its no longer possible to create further
1705 |      // duplicate transactions descending from the known pairs either.
1706 |      // If we're on the known chain at height greater than where BIP34 activated, we can save the db accesses needed for the BIP30 check.
1707 | +    assert(pindex->pprev && "pindex->pprev != nullptr assumed.");

sipa commented at 4:19 PM on August 25, 2017:

Repeating the condition in a message is not very useful.

meshcollider commented at 12:53 PM on August 26, 2017:

Agree with @sipa, same thing as #11133