Docs: Add python3 to list of dependencies on some platforms #11136

pull danra wants to merge 1 commits into bitcoin:master from danra:patch-1 changing 2 files +3 −3

danra commented at 4:05 PM on August 25, 2017: contributor

python3 is required for running the unit tests on macOS.

Without python3 on macOS, 'make check' fails because /test/util/bitcoin-util-test.py fails to find python3.
MarcoFalke commented at 4:39 PM on August 25, 2017: member

The dependencies for the functional tests are mentioned in https://github.com/danra/bitcoin/tree/master/test#dependencies
danra commented at 4:43 PM on August 25, 2017: contributor

@MarcoFalke OK, but I don't think it makes sense for build_osx.md to recommend running make check on one hand, while on the other hand not mentioning the dependencies for running it when listing the dependencies earlier.
MarcoFalke commented at 4:43 PM on August 25, 2017: member

The readme in src/test mentions that the unit tests can be run with make check, but doesn't mention the python3 dependency. We might combine the src/test readme into the /test/ readme and then link to the combined readme from the /doc/ subdir.
fanquake added the label Docs and Output on Aug 25, 2017
laanwj commented at 7:52 AM on August 28, 2017: member

Concept ACK, as python 3 is required for the unit tests (not just the functional tests in test/functional) we should just mention it as dependency. (it used to be the case that make check could be done without python 3)
MarcoFalke commented at 8:20 PM on August 28, 2017: member

Fine with me, but please also update the dependencies for ubuntu/fedora
danra commented at 8:28 PM on August 28, 2017: contributor

@MarcoFalke I've only checked the dependencies on my macOS. Should I just add python3 to the build documentation for the platforms you mentioned as well?
MarcoFalke commented at 8:56 PM on August 28, 2017: member

Yes, python3 will be required on the other platforms as well.
danra renamed this:
~~Docs: Add python3 to list of dependencies on macOS~~
Docs: Add python3 to list of dependencies on some platforms
on Aug 30, 2017

Add python3 to list of dependencies on some platforms

python3 is required for running the unit tests on macOS, Ubuntu and Fedora.

Without python3 installed, 'make check' fails because /test/util/bitcoin-util-test.py fails to find python3.

7bb5d3000c

danra force-pushed on Aug 30, 2017
danra commented at 8:30 PM on August 30, 2017: contributor

@MarcoFalke Done
MarcoFalke commented at 11:20 AM on September 1, 2017: member

utACK 7bb5d30
jnewbery commented at 7:31 PM on September 1, 2017: member

utACK 7bb5d3000ca4b74c3701cf49eaf63e5a37dfe7ac
fanquake commented at 8:40 AM on September 2, 2017: member

utACK 7bb5d30
MarcoFalke merged this on Sep 2, 2017
MarcoFalke closed this on Sep 2, 2017
MarcoFalke referenced this in commit 108222b9c3 on Sep 2, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels