Fix boost headers included as user instead of system headers #11164

pull danra wants to merge 1 commits into bitcoin:master from danra:fix/boost-system-includes changing 3 files +8 −9

danra commented at 7:04 PM on August 26, 2017: contributor

In most of the project, boost headers are included as system headers. Fix the few inconsistent places where they aren't.

Fix boost headers included as user instead of system headers

In most of the project, boost headers are included as system headers.
Fix the few inconsistent places where they aren't.

5ac072caa2

laanwj added the label Refactoring on Aug 28, 2017
laanwj commented at 8:44 AM on August 28, 2017: member

utACK https://github.com/bitcoin/bitcoin/pull/11164/commits/5ac072caa242d7ecf724e0c3a23f4a7c477a3a1e
fanquake commented at 10:22 AM on August 28, 2017: member

utACK 5ac072c

in configure.ac:830 in 5ac072caa2

 826 | @@ -827,14 +827,14 @@ TEMP_CPPFLAGS="$CPPFLAGS"
 827 |  CPPFLAGS="$CPPFLAGS $BOOST_CPPFLAGS"
 828 |  AC_MSG_CHECKING([for mismatched boost c++11 scoped enums])
 829 |  AC_LINK_IFELSE([AC_LANG_PROGRAM([[
 830 | -  #include "boost/config.hpp"
 831 | -  #include "boost/version.hpp"
 832 | +  #include <boost/config.hpp>

laanwj commented at 1:29 PM on August 28, 2017:

@theuni as this is part of a check, I wonder if there was a specific resaon for using " instead of <?

fanquake commented at 1:32 PM on August 28, 2017:

For reference this code came from #7302

laanwj merged this on Sep 5, 2017
laanwj closed this on Sep 5, 2017
laanwj referenced this in commit 38a54a50fa on Sep 5, 2017
PastaPastaPasta referenced this in commit 8dc22f37bf on Sep 20, 2019
PastaPastaPasta referenced this in commit a3ac7cafa9 on Sep 23, 2019
PastaPastaPasta referenced this in commit be9f3c8f52 on Sep 24, 2019
PastaPastaPasta referenced this in commit 18de213986 on Nov 19, 2019
PastaPastaPasta referenced this in commit 0b5933fb9f on Nov 21, 2019
PastaPastaPasta referenced this in commit 412294ffba on Dec 9, 2019
PastaPastaPasta referenced this in commit 94d2240ede on Jan 1, 2020
PastaPastaPasta referenced this in commit 61ab292d9a on Jan 2, 2020
PastaPastaPasta referenced this in commit b2b058f42c on Jan 2, 2020
PastaPastaPasta referenced this in commit 806849470b on Jan 2, 2020
ckti referenced this in commit 52aed5f83a on Mar 28, 2021
gades referenced this in commit f029daf40e on Jun 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels