Remove redundant testutil.cpp|h files #11234

pull meshcollider wants to merge 1 commits into bitcoin:master from meshcollider:201709_remove_testutil changing 6 files +3 −40
  1. meshcollider commented at 4:37 am on September 5, 2017: contributor

    The only function in testutil.cpp, GetTempPath() simply called fs::temp_directory_path() directly. This just tidies things up by removing that redundant function and the file containing it

    I can understand wanting a general util file for tests to use, but if there’s nothing in it, we might as well remove it, it can always be added back later when it’s put to use.

  2. Remove redundant testutil files d1138e3620
  3. fanquake added the label Refactoring on Sep 5, 2017
  4. fanquake added the label Tests on Sep 5, 2017
  5. dcousens approved
  6. practicalswift commented at 6:21 am on September 5, 2017: contributor
    utACK d1138e36208dac87a27f415f39c70377636e93f1. Nice cleanup!
  7. laanwj commented at 3:51 pm on September 5, 2017: member

    I can understand wanting a general util file for tests to use

    That’s why I kept it around, but yeah, if someone wants a test utility cpp/h they can re-add it.

  8. MarcoFalke commented at 5:43 pm on September 5, 2017: member
    utACK d1138e36208dac87a27f415f39c70377636e93f1. The file collapsed after removal of boost.
  9. laanwj merged this on Sep 5, 2017
  10. laanwj closed this on Sep 5, 2017

  11. laanwj referenced this in commit 001041df81 on Sep 5, 2017
  12. meshcollider deleted the branch on Sep 6, 2017
  13. MarcoFalke referenced this in commit f0b67954f0 on Oct 3, 2017
  14. PastaPastaPasta referenced this in commit 82f51c1b76 on Sep 20, 2019
  15. PastaPastaPasta referenced this in commit b7718ba8fb on Sep 23, 2019
  16. PastaPastaPasta referenced this in commit 4bab1f506a on Sep 24, 2019
  17. codablock referenced this in commit ec892d459d on Sep 24, 2019
  18. barrystyle referenced this in commit 3f711d69e5 on Jan 22, 2020
  19. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me