travis: Assert default datadir isn’t created, Run scripted diff only once #11260

1. 
   MarcoFalke commented at 10:27 pm on September 6, 2017: member

   It is sufficient to check the scripted diffs on one arch, i.e. CHECK_DOC==1.

   Also, the default datadir should not be created by just running the tests.

2. MarcoFalke added the label Tests on Sep 6, 2017
3. laanwj assigned theuni on Sep 6, 2017
4. travis: Assert default datadir isn't created, Run scripted diff only once fa40b0eb51
5. MarcoFalke force-pushed on Sep 6, 2017
6. MarcoFalke renamed this:
   travis: Check that default datadir is never created, Check SHAs only once
   travis: Assert default datadir isn't created, Run scripted diff only once
   on Sep 6, 2017
7. 
   practicalswift commented at 11:25 pm on September 6, 2017: contributor

   Concept ACK regarding the assertion

   Is it due to performance reasons we want to run scripted diff only for the arm-linux-gnueabihf build (CHECK_DOC=1)? One benefit of doing the scripted diff for all builds is to make it apparent from the build status overview that all builds fails. If only arm-linux-gnueabihf is red when a scripted diff fails it might look like a platform specific issue and hence require further investigation to see that it is a general scripted diff failure.

   This argument could be raised for all checks that for performance reasons are specific to a given Travis build, but scripted diff should be fairly quick in the general case?

8. 
   MarcoFalke commented at 11:28 pm on September 6, 2017: member

   No need to run an arch independent check on each arch. If you feel like factoring out the CHECK_DOC into a different build stage (c.f. #11004 (comment)); Go for it!
9. 
   practicalswift commented at 11:32 pm on September 6, 2017: contributor

   @MarcoFalke Makes sense! Factoring out CHECK_DOC into a different build stage sounds like a good plan.

   Concept ACK :-)

10. 
    MarcoFalke commented at 11:39 pm on September 6, 2017: member

    So without 5368614aa106b96e02ffb9e68eb86ebe197bc07f, it actually fails: https://travis-ci.org/MarcoFalke/bitcoin/jobs/272689632
11. 
    laanwj commented at 11:52 pm on September 6, 2017: member

    Concept ACK, will leave review of the travis changes to @theuni
12. 
    meshcollider commented at 2:22 am on September 7, 2017: contributor

    Concept ACK, the Travis changes look right but I don’t know enough about it to say for sure :)
13. theuni approved
14. 
    theuni commented at 6:00 pm on September 7, 2017: member

    Looks good to me. utACK fa40b0eb514e77928a13a007df170e5ede18ee3e
15. laanwj assigned laanwj on Sep 7, 2017
16. 
    laanwj commented at 7:16 pm on September 7, 2017: member

    Thanks, will merge after the general issue with travis is resolved.
17. 
    MarcoFalke commented at 8:10 pm on September 7, 2017: member

    This is orthogonal to the travis issue and should not affect it.
18. MarcoFalke merged this on Sep 7, 2017
19. MarcoFalke closed this on Sep 7, 2017

    ---

20. MarcoFalke referenced this in commit 52f8877525 on Sep 7, 2017
21. MarcoFalke deleted the branch on Sep 7, 2017
22. MarcoFalke referenced this in commit 16e41844e7 on Sep 11, 2017
23. DrahtBot locked this on Sep 8, 2021

Contributors
MarcoFalke practicalswift laanwj meshcollider theuni

Labels
Tests