rpc: update cli for estimate*fee argument rename #11267

1. 
   laanwj commented at 4:20 PM on September 7, 2017: member

   The first argument of estimaterawfee was renamed from nblocks to conf_target in 06bcdb8da64502a64df03f3c89fbc6ccb72cd349. Update the client-side table as well. This makes #10753 pass again.

2. laanwj added the label RPC/REST/ZMQ on Sep 7, 2017
3. 
   MarcoFalke commented at 4:44 PM on September 7, 2017: member

   Is this for 0.15.0?

4. laanwj renamed this:
   rpc: update cli for estimatefee argument rename
   rpc: update cli for estimaterawfee argument rename
   on Sep 7, 2017
5. 
   laanwj commented at 5:10 PM on September 7, 2017: member

   0.15.1 i'd say - it's not critical enough to hold up the release for, we could add an errata or such to the release notes

   I'll also add a commit to fix the argument name for estimatesmartfee.

6. laanwj added this to the milestone 0.15.1 on Sep 7, 2017
7. laanwj added the label Needs backport on Sep 7, 2017
8. 
   morcos commented at 5:20 PM on September 7, 2017: member

   utACK b0a404b

   Thanks and sorry. Note the mining.cpp change already exists in the 0.15 branch.

9. laanwj renamed this:
   rpc: update cli for estimaterawfee argument rename
   rpc: update cli for estimate*fee argument rename
   on Sep 7, 2017
10. 
    morcos commented at 6:59 PM on September 7, 2017: member

    tested ACK now... not sure about the travis failure , perhaps unrelated?

11. 
    meshcollider commented at 8:11 PM on September 7, 2017: contributor

    utACK https://github.com/bitcoin/bitcoin/commit/b0a404be258b3da0c7343314b6a38ffd41f10818 Yeah 1 Travis failure is spurious and the other is related to #11270 I believe

12. rpc: update cli for estimatefee argument rename

    The first argument of estimatesmartfee was renamed from nblocks to
    conf_target in 06bcdb8da64502a64df03f3c89fbc6ccb72cd349. Update the
    client-side table as well.

    24697c40ee
13. rpc: make estimatesmartfee argument naming consistent with documentation

    Part of this was a reversion in ec6902d0ea2bbe75179684fc71849d5e34647a14.

    5acd82de9a
14. laanwj force-pushed on Sep 7, 2017
15. 
    fanquake commented at 11:40 AM on September 8, 2017: member

    utACK https://github.com/bitcoin/bitcoin/pull/11267/commits/5acd82de9ad6df8cab922da66d49b8ff2bd35439

16. 
    jtimon commented at 2:00 PM on September 8, 2017: contributor

    utACK 5acd82de9ad6df8cab922da66d49b8ff2bd35439 The travis failure seems to be in master. It seems -usehd is not documented.

17. 
    MarcoFalke commented at 3:57 AM on September 10, 2017: member

    https://github.com/laanwj/bitcoin/blob/5acd82de9ad6df8cab922da66d49b8ff2bd35439/src/rpc/mining.cpp#L776 is still wrong? Forget that, it was estimatefee.

    Nit: Mention "estimaterawfee" in the body of the first commit.

    utACK 5acd82de9ad6df8cab922da66d49b8ff2bd35439

18. MarcoFalke merged this on Sep 12, 2017
19. MarcoFalke closed this on Sep 12, 2017

    ---

20. MarcoFalke referenced this in commit c377feaad8 on Sep 12, 2017
21. MarcoFalke referenced this in commit 921542e0bd on Oct 3, 2017
22. MarcoFalke referenced this in commit b1a6c94683 on Oct 3, 2017
23. MarcoFalke removed the label Needs backport on Oct 4, 2017
24. codablock referenced this in commit 654c78fa29 on Sep 25, 2019
25. barrystyle referenced this in commit cdb52ecec9 on Jan 22, 2020
26. MarcoFalke locked this on Sep 8, 2021

Contributors

laanwjMarcoFalkemorcosmeshcolliderfanquakejtimon

Milestone
0.15.2