[Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type #11269

pull donaloconnor wants to merge 1 commits into bitcoin:master from donaloconnor:fix_params_branch changing 2 files +2 −2

donaloconnor commented at 6:16 PM on September 7, 2017: contributor

CTxMemPoolEntry::CTxMemPoolEntry's modifySigOps parameter is int while update_ancestor_state::modifySigOpsCost is int64_t. This issue was raised in #11165. It looks like the function paramaters were not changed in commit 72abd2c

This will avoid unexpected truncation of int64_t -> int
Fix CTxMemPoolEntry::UpdateAncestorState: modifySigOps param type int -> int64_t 203a4aa31e
donaloconnor commented at 8:07 PM on September 7, 2017: contributor

Sorry I meant to refer to commit 2b1f6f9ccf36f1e0a2c9d99154e1642f796d7c2b. update_ancestor_state : int modifySigOps was changed to int64_t modifySigOpsCost
fanquake added the label Mempool on Sep 8, 2017
Leviathn commented at 4:25 PM on September 13, 2017: none

Error in title..
TheBlueMatt commented at 3:24 PM on September 20, 2017: member

utACK 203a4aa31eee402755f7156593228ab55407cc47, though as @Leviathn points out, this is not "trivial" (by our definition, the project generally considers "trivial" to only include comment and sometimes string changes, never code changes).
donaloconnor renamed this:
~~[Trivial Fix] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type~~
[Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type
on Sep 20, 2017
donaloconnor commented at 3:32 PM on September 20, 2017: contributor

Updated title to [Mempool] - sorry I misread the guidelines :)

Notably, refactors (change of function arguments and code reorganization) and changes in behavior should not be marked as trivial.
MarcoFalke commented at 8:33 PM on November 10, 2017: member

utACK 203a4aa31
MarcoFalke merged this on Nov 10, 2017
MarcoFalke closed this on Nov 10, 2017
MarcoFalke referenced this in commit 61fb80660f on Nov 10, 2017
PastaPastaPasta referenced this in commit b3702d1cb0 on Jan 17, 2020
PastaPastaPasta referenced this in commit 7a73bcf66a on Jan 22, 2020
PastaPastaPasta referenced this in commit 1990f11450 on Jan 22, 2020
PastaPastaPasta referenced this in commit c97e8c64f8 on Jan 29, 2020
deadalnix referenced this in commit 1efbec18e0 on Mar 5, 2020
ftrader referenced this in commit a693072c55 on Apr 16, 2020
ckti referenced this in commit 992a390953 on Mar 28, 2021
gades referenced this in commit 6398e64d64 on Jun 24, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11165 Bug: Possible overflow calling CTxMemPoolEntry::UpdateAncestorState()