[Docs] Update CONTRIBUTING.md to reduce unnecessary review workload #11276

jonasschnelli commented at 9:22 PM on September 7, 2017: contributor

The current workload for reviewing pull requests is relatively high and trivial, non-beneficial pull requests tend to slow down the overall development process.

We may want to directly close trivial, non-beneficially pull requests during time of high pull request load.

This PR would prepare for possible direct PR closing.

jonasschnelli added the label Docs and Output on Sep 7, 2017

laanwj commented at 9:26 PM on September 7, 2017: member

Concept ACK

in CONTRIBUTING.md:164 in e27effaf8d outdated

 156 | @@ -157,6 +157,13 @@ behaviour of code within the pull request (bugs must be preserved as is).
 157 |  Project maintainers aim for a quick turnaround on refactoring pull requests, so
 158 |  where possible keep them short, uncomplex and easy to verify.
 159 |  
 160 | +Refactoring pull requests should not be made by new contributors. It requires a
 161 | +certain level of experience to know where the code belongs to and to understand
 162 | +the full ramification (including rebase effort of open pull requests).
 163 | +
 164 | +Refactoring and trivial pull requests with no clear benefits may be directly

laanwj commented at 9:26 PM on September 7, 2017:

s/directly/immediately/ I'd say

in CONTRIBUTING.md:160 in e27effaf8d outdated

 156 | @@ -157,6 +157,13 @@ behaviour of code within the pull request (bugs must be preserved as is).
 157 |  Project maintainers aim for a quick turnaround on refactoring pull requests, so
 158 |  where possible keep them short, uncomplex and easy to verify.
 159 |  
 160 | +Refactoring pull requests should not be made by new contributors. It requires a

laanwj commented at 9:27 PM on September 7, 2017:

"Refactoring changes" maybe, or "Pull requests that refactor the code"

in CONTRIBUTING.md:165 in e27effaf8d outdated

 156 | @@ -157,6 +157,13 @@ behaviour of code within the pull request (bugs must be preserved as is).
 157 |  Project maintainers aim for a quick turnaround on refactoring pull requests, so
 158 |  where possible keep them short, uncomplex and easy to verify.
 159 |  
 160 | +Refactoring pull requests should not be made by new contributors. It requires a
 161 | +certain level of experience to know where the code belongs to and to understand
 162 | +the full ramification (including rebase effort of open pull requests).
 163 | +
 164 | +Refactoring and trivial pull requests with no clear benefits may be directly
 165 | +closed by the maintainers to reduce unnecessary workload on reviewing.

MarcoFalke commented at 9:32 PM on September 7, 2017:

Maybe add

Any refactoring pull request may be closed when it doesn't attract anyone willing to review.

MarcoFalke commented at 9:32 PM on September 7, 2017: member

utACK e27effaf8dfde49acfd6bea96eb0e4754ccaead1. Couldn't find a way to test this without merging.

Update CONTRIBUTRING.md to reduce unnecesarry review workload 91c39e38d9

jonasschnelli force-pushed on Sep 7, 2017

jonasschnelli commented at 11:58 PM on September 7, 2017: contributor

Updated.

fanquake commented at 5:41 AM on September 8, 2017: member

Seems reasonable. There have also been a few cases recently where multiple PRs have been opened when the changes should have all been in a single PR.

utACK https://github.com/bitcoin/bitcoin/pull/11276/commits/91c39e38d9f59331b77ec9017ea147725a32f2d1

promag commented at 7:53 AM on September 8, 2017: member

Typo in PR title and commit message CONTRIBUTING.md.

Maybe add something along "Instead new contributors should discuss refactors with other developers in the usual channels."

Concept ACK.

fanquake renamed this:
~~Update CONTRIBUTRING.md to reduce unnecesarry review workload~~
[Docs] Update CONTRIBUTING.md to reduce unnecessary review workload
on Sep 8, 2017

MarcoFalke merged this on Sep 10, 2017

MarcoFalke closed this on Sep 10, 2017

MarcoFalke referenced this in commit ee50c9e487 on Sep 10, 2017

DrahtBot locked this on Sep 8, 2021