Add -usehd to excluded args in check-doc.py #11285

pull meshcollider wants to merge 1 commits into bitcoin:master from meshcollider:201709_fix_usehd_checkdocs changing 1 files +1 −1
  1. meshcollider commented at 7:24 AM on September 8, 2017: contributor

    All Travis builds on master are currently failing due to contrib/devtools/check-doc.py picking up -usehd in src/wallet/wallet.cpp#L3845 as an undocumented argument (removed in #11250). Just need to add it to the list of unsupported, deprecated and duplicate args in check-doc.py so that it's ignored. Otherwise all builds on top of #11250 will fail until this is merged.

  2. Add -usehd to excluded args in check-doc.py 7d03418aea
  3. fanquake added the label Tests on Sep 8, 2017
  4. fanquake commented at 7:26 AM on September 8, 2017: member

    Failing as below, however it looks like it's only the arm-linux builds?

    0.08s$ if [ "$CHECK_DOC" = 1 ]; then contrib/devtools/check-doc.py; fi
    Args used        : 145
    Args documented  : 172
    Args undocumented: 1
    set(['-usehd'])
    Args unknown     : 28
    set(['-blockminsize', '-version', '-addnode', '-debug', '-zmqpubrawtx', '-rpcauth', '-zmqpubhashtx', '-rpcallowip', '-zmqpubhashblock', '-vbparams', '-h', '-socks', '-rpcbind', '-onlynet', '-connect', '-help', '-seednode', '-whitelist', '-bind', '-loadblock', '-uacomment', '-zmqpubrawblock', '-whitebind', '-fuzzmessagestest', '-debugexclude', '-wallet', '-externalip', '-?'])
    The command "if [ "$CHECK_DOC" = 1 ]; then contrib/devtools/check-doc.py; fi" failed and exited with 1 during .
    Your build has been stopped.
    
  5. meshcollider commented at 7:27 AM on September 8, 2017: contributor

    @fanquake it's only on the builds which export CHECK_DOC=1 to run check-doc.py

  6. promag commented at 7:43 AM on September 8, 2017: member

    ACK 7d03418.

  7. fanquake commented at 7:56 AM on September 8, 2017: member

    travis-has-passed ACK 7d03418

    Does a reminder need to be added to the docs somewhere, so this doesn't happen again?

  8. meshcollider commented at 8:09 AM on September 8, 2017: contributor

    Unsure where it would be suitable to put such a thing, but if you have a place in mind it would probably be a good idea :+1:

  9. promag commented at 11:29 AM on September 8, 2017: member

    Does a reminder need to be added to the docs somewhere, so this doesn't happen again?

    This problem should have been fixed in #11250 where travis should be broken (but the build was cancelled) so I guess there is no need for documentation.

  10. jimpo commented at 5:29 PM on September 8, 2017: contributor

    ACK 7d03418

  11. achow101 commented at 5:39 PM on September 8, 2017: member

    ACK 7d03418aeab039775f8790718080ad10774fc4d0

  12. sipa merged this on Sep 8, 2017
  13. sipa closed this on Sep 8, 2017

  14. sipa referenced this in commit 3255d6347b on Sep 8, 2017
  15. meshcollider deleted the branch on Sep 9, 2017
  16. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me