Closes #11243
Adds “Requires a new wallet backup” text to addwitnessaddress, importprivkey, importmulti, importaddress, importpubkey, and addmultisigaddress. Also adds a warning to dumpwallet that backing up the seed alone is not sufficient to back up non-HD addresses
61@@ -62,7 +62,7 @@ std::string DecodeDumpString(const std::string &str) {
62 for (unsigned int pos = 0; pos < str.length(); pos++) {
63 unsigned char c = str[pos];
64 if (c == '%' && pos+2 < str.length()) {
65- c = (((str[pos+1]>>6)*9+((str[pos+1]-'0')&15)) << 4) |
66+ c = (((str[pos+1]>>6)*9+((str[pos+1]-'0')&15)) << 4) |
643@@ -644,7 +644,7 @@ UniValue dumpwallet(const JSONRPCRequest& request)
644 file << strprintf("# mined on %s\n", EncodeDumpTime(chainActive.Tip()->GetBlockTime()));
645 file << "\n";
646
647- // add the base58check encoded extended master if the wallet uses HD
648+ // add the base58check encoded extended master if the wallet uses HD
dumpwallet that just backing up the private masterkey is likely insufficient?
600@@ -601,6 +601,7 @@ UniValue dumpwallet(const JSONRPCRequest& request)
601 throw std::runtime_error(
602 "dumpwallet \"filename\"\n"
603 "\nDumps all wallet keys in a human-readable format.\n"
604+ "Note that if your wallet contains keys which are not derived from your HD seed (e.g. imported keys), these are not covered by only backing up the seed itself, and must be backed up too.\n"
I suppose for completeness importwallet may need the (rather astoundingly obvious) “Requires a new backup” note.
I guess we dont want to note anything about keypool topup leading to needing backups in things like “getnewaddress” (for non-HD wallets)? What about explicit ones like “keypoolrefill”? And things that always wipe keypool like encryptwallet? I guess probably not?
Similarly, I suppose we dont care about listing things like move/sendfrom which change wallet fileds for F$#King accounts?
600@@ -601,6 +601,7 @@ UniValue dumpwallet(const JSONRPCRequest& request)
601 throw std::runtime_error(
602 "dumpwallet \"filename\"\n"
603 "\nDumps all wallet keys in a human-readable format.\n"
Dumps all wallet derived keys in a human-readable format. help cleanup the confusion?
(e.g. ensure you back up the whole dumpfile) (note that I didn’t follow the suggested edit by mess110 because it’s wrong, is that what you were looking at?). Are you suggesting mentioning that those imported scripts aren’t backed up, or?
The description does currently specifically refer to ‘keys’ not scripts or segwit addresses. But is there any reason scripts aren’t also dumped too?
No. just that (AFAIK) no one implemented that yet. Ideally a dumpwallet would not lose any relevant information.
600@@ -601,6 +601,7 @@ UniValue dumpwallet(const JSONRPCRequest& request)
601 throw std::runtime_error(
602 "dumpwallet \"filename\"\n"
603 "\nDumps all wallet keys in a human-readable format to a server-side file. This does not allow overwriting existing files.\n"
604+ "Note that if your wallet contains keys which are not derived from your HD seed (e.g. imported keys), these are not covered by only backing up the seed itself, and must be backed up too (e.g. ensure you back up the whole dumpfile).\n"
1109@@ -1110,7 +1110,7 @@ UniValue addmultisigaddress(const JSONRPCRequest& request)
1110 if (request.fHelp || request.params.size() < 2 || request.params.size() > 3)
1111 {
1112 std::string msg = "addmultisigaddress nrequired [\"key\",...] ( \"account\" )\n"
1113- "\nAdd a nrequired-to-sign multisignature address to the wallet.\n"
1114+ "\nAdd a nrequired-to-sign multisignature address to the wallet. Requires a new wallet backup.\n"
“nrequired-to-sign multisignature”
Only comment, I’m assuming this isn’t a typo, and is a reference to the number of required signatures needed for the multisig address?