Deadlock detection bogus #11327

issue NicolasDorier opened this issue on September 14, 2017

NicolasDorier commented at 1:52 PM on September 14, 2017: contributor

At startup, seems to happen when rebroadcasting wallet's transactions, running 0.15 rc3: (enable-debug)

2017-09-14 13:17:09 POTENTIAL DEADLOCK DETECTED
2017-09-14 13:17:09 Previous lock order was:
2017-09-14 13:17:09  cs_main  wallet/wallet.cpp:1655
2017-09-14 13:17:09  cs_wallet  wallet/wallet.cpp:1655
2017-09-14 13:17:09  (1) mempool.cs  wallet/wallet.cpp:1677
2017-09-14 13:17:09  cs_main  wallet/wallet.cpp:1233
2017-09-14 13:17:09  (2) cs_wallet  wallet/wallet.cpp:1233
2017-09-14 13:17:09 Current lock order is:
2017-09-14 13:17:09  cs_main  wallet/wallet.cpp:1655
2017-09-14 13:17:09  (2) cs_wallet  wallet/wallet.cpp:1655
2017-09-14 13:17:09  (1) mempool.cs  wallet/wallet.cpp:1677
Assertion failed!

Program: C:\Program Files\Bitcoin-0.15.0\bin\bitcoind.exe

~Tried with #11126 but no improvement.~ (I screwed up the deployement so I have not tried actually, but the error seems to be different lock path)

I am unsure if the problem is in the lock detection (obviously no deadlock possible here), or in the actual code using an unsafe construct.

TheBlueMatt commented at 5:31 PM on September 14, 2017: member

Indeed, more of a bug in the detection code than anything given they're all duplicate locks, though maybe better to take #10286 than fix it, since I know some folks want to start pushing towards not using recursive locks.
laanwj added the label Bug on Sep 15, 2017
MarcoFalke commented at 1:46 AM on January 24, 2018: member

Presumably fixed by #11126
MarcoFalke closed this on Jan 24, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11126 Acquire cs_main lock before cs_wallet during wallet initialization