In the case of CKey's destructor, it seems to have been an oversight in #8753 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have a performance impact (requiring a pool allocation/copy/free, rather than just handing over the pointer from one CKey to another)
Remove some unused functions and methods #11385
pull sipa wants to merge 1 commits into bitcoin:master from sipa:201709_misc_cleanups changing 3 files +0 −21-
sipa commented at 6:45 AM on September 22, 2017: member
-
46c90437f9
Remove some unused functions and methods
In the case of CKey's destructor, it seems to have been an oversight in f4d1fc259 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have a performance impact.
- dcousens approved
-
theuni commented at 6:54 AM on September 22, 2017: member
utACK 46c90437f9efbabcb5c810cd82b00a9e5d1c5cd7.
Out of curiosity, did you just happen upon CKey's useless dtor? I noticed some of these a while back which I believe have been fixed (CScript/prevector iirc), but if there's some simple static analysis tool that points them out, I'd like to get all of 'em.
-
- fanquake added the label Refactoring on Sep 22, 2017
-
promag commented at 7:25 AM on September 22, 2017: member
utACK 46c9043.
-
practicalswift commented at 8:31 AM on September 22, 2017: contributor
utACK 46c90437f9efbabcb5c810cd82b00a9e5d1c5cd7
-
laanwj commented at 11:30 AM on September 22, 2017: member
- laanwj merged this on Sep 22, 2017
- laanwj closed this on Sep 22, 2017
- laanwj referenced this in commit 94c9015bca on Sep 22, 2017
- underdarkskies referenced this in commit 8d2c4446a3 on Jul 3, 2018
- jasonbcox referenced this in commit 97b7b1b238 on May 15, 2019
- jonspock referenced this in commit 085baea45c on Jun 13, 2019
- jonspock referenced this in commit 525a07dc95 on Jun 13, 2019
- PastaPastaPasta referenced this in commit bad429f601 on Dec 22, 2019
- PastaPastaPasta referenced this in commit d0e6a1c4e4 on Jan 2, 2020
- PastaPastaPasta referenced this in commit c5e1cfe005 on Jan 4, 2020
- PastaPastaPasta referenced this in commit d15dd02d78 on Jan 4, 2020
- PastaPastaPasta referenced this in commit d6df1e605a on Jan 10, 2020
- PastaPastaPasta referenced this in commit f6a6860cbc on Jan 10, 2020
- PastaPastaPasta referenced this in commit 44b47017ef on Jan 10, 2020
- PastaPastaPasta referenced this in commit dd8e0c0153 on Jan 12, 2020
- zkbot referenced this in commit 5ef5d8d268 on Jul 31, 2020
- zkbot referenced this in commit 7d94064616 on Sep 29, 2020
- ckti referenced this in commit 7a256c4b08 on Mar 28, 2021
- furszy referenced this in commit 60d36292bc on Jul 26, 2021
- MarcoFalke locked this on Sep 8, 2021
Labels