[docs] document scripted-diff #11390

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:document_scripted_diff changing 1 files +20 −0

jnewbery commented at 11:34 PM on September 23, 2017: member

Document scripted-diffs in developer-notes.md

I sometimes comment on PRs that a scripted-diff would be appropriate, but I don't have any documentation to point to. Fix that.
fanquake added the label Docs and Output on Sep 23, 2017
sipa commented at 11:55 PM on September 23, 2017: member

Typo: indentical (or is that a neologism to mean "identical indentation"?)
jnewbery force-pushed on Sep 23, 2017
jnewbery commented at 12:01 AM on September 24, 2017: member

Typo: indentical (or is that a neologism to mean "identical indentation"?)

Not a neologism. Just plain old cacography. Now fixed.

in doc/developer-notes.md:555 in b1320d2778 outdated

 548 | @@ -549,6 +549,26 @@ Git and GitHub tips
 549 |    or `git fetch upstream-pull`. Afterwards, you can use `upstream-pull/NUMBER/head` in arguments to `git show`,
 550 |    `git checkout` and anywhere a commit id would be acceptable to see the changes from pull request NUMBER.
 551 |  
 552 | +Scripted diffs
 553 | +--------------
 554 | +
 555 | +For reformating and refactoring commits where the changes can be easily automated using a bash script, we use

meshcollider commented at 1:43 AM on September 24, 2017:

typo: reformating -> reformatting

jnewbery commented at 12:17 PM on September 24, 2017:

thanks. fixed

meshcollider commented at 1:43 AM on September 24, 2017: contributor

Concept ACK

in doc/developer-notes.md:570 in b1320d2778 outdated

 565 | +    - `-BEGIN VERIFY SCRIPT-`
 566 | +    - `-END VERIFY SCRIPT-`
 567 | +
 568 | +The scripted-diff is verified by the tool `contrib/devtools/commit-script-check.sh`
 569 | +
 570 | +Commit `bb81e1735575e1c00e808326735168cc9810c174` is an example of a scripted-diff.

promag commented at 9:11 AM on September 24, 2017:

Use short version?

jnewbery commented at 12:17 PM on September 24, 2017:

ok. changed

promag commented at 9:11 AM on September 24, 2017: member

LGTM.
[docs] document scripted-diff 90ab62c451
jnewbery force-pushed on Sep 24, 2017
achow101 commented at 11:49 PM on September 24, 2017: member

ACK 90ab62c4512942f1d252259a892e1cbeeb92789e
fanquake commented at 12:31 AM on September 25, 2017: member

utACK 90ab62c
sipa commented at 12:38 AM on September 25, 2017: member

ACK
sipa merged this on Sep 25, 2017
sipa closed this on Sep 25, 2017
sipa referenced this in commit 12ed800ab8 on Sep 25, 2017
PastaPastaPasta referenced this in commit 743dcedf86 on Dec 22, 2019
PastaPastaPasta referenced this in commit d3efc91232 on Jan 2, 2020
PastaPastaPasta referenced this in commit c0a01e0017 on Jan 4, 2020
PastaPastaPasta referenced this in commit b4cfde8d4e on Jan 4, 2020
PastaPastaPasta referenced this in commit 84b08ec5c5 on Jan 10, 2020
PastaPastaPasta referenced this in commit 5754fdb53a on Jan 10, 2020
PastaPastaPasta referenced this in commit f9b5bae111 on Jan 10, 2020
PastaPastaPasta referenced this in commit 6f4263652e on Jan 12, 2020
zkbot referenced this in commit 311a079dd5 on Oct 27, 2020
ckti referenced this in commit ed4df86e86 on Mar 28, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels