Add state message print to AcceptBlock failure message. #11406

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2017-09-checkblock-fail-print changing 1 files +1 −1

TheBlueMatt commented at 8:25 PM on September 26, 2017: member

This should make it easier to debug issues where the CheckBlock at the top of ProcessNewBlock fails (which does not print, in contrast to AcceptBlock, which always prints).

This was motivated by #11371 which appears to be exactly such a case, and is not debuggable from the information provided. Not sure how much this would have helped in that case, but it is kinda weird that we can reject a block without ever printing why.

Add state message print to AcceptBlock failure message.

This should make it easier to debug issues where the CheckBlock at
the top of ProcessNewBlock fails (which does not print, in contrast
to AcceptBlock, which always prints).

6643b80d1c

instagibbs commented at 9:48 PM on September 26, 2017: member

Any reason why more state errors, like just below these lines, shouldn't also be printed? Not to derail this...
fanquake added the label Validation on Sep 26, 2017
TheBlueMatt commented at 5:05 PM on September 27, 2017: member

I believe all errors in the ProcessNewBlock call trace are printed at the place the error is set on the state object (with the exception of CheckBlock) hence the addition to only CheckBlock here.
jonasschnelli commented at 2:54 AM on September 28, 2017: contributor

utACK 6643b80d1c0134bc8ef5edd65fbe09c8b63b01d3
MarcoFalke added the label Docs and Output on Sep 29, 2017
laanwj merged this on Oct 4, 2017
laanwj closed this on Oct 4, 2017
laanwj referenced this in commit e12522dfda on Oct 4, 2017
PastaPastaPasta referenced this in commit eba7913a47 on Dec 22, 2019
PastaPastaPasta referenced this in commit da4a2d8e72 on Jan 2, 2020
PastaPastaPasta referenced this in commit 99b9a809a7 on Jan 4, 2020
PastaPastaPasta referenced this in commit 79cb2b8c86 on Jan 12, 2020
PastaPastaPasta referenced this in commit b1438357fe on Jan 12, 2020
PastaPastaPasta referenced this in commit d38391908b on Jan 12, 2020
PastaPastaPasta referenced this in commit f27db9111f on Jan 12, 2020
PastaPastaPasta referenced this in commit 1bf08575c9 on Jan 12, 2020
PastaPastaPasta referenced this in commit 44349a5245 on Jan 12, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11371 Bitcoin 0.15.0 repeatedly bans only connect peer