Trivial: Fix parameter name typo in ErasePurpose walletdb method #11408

pull PierreRochard wants to merge 1 commits into bitcoin:master from PierreRochard:walletdb-typo changing 1 files +2 −2
  1. PierreRochard commented at 10:08 PM on September 26, 2017: contributor

    The header file has the correct method signature and the one usage in CWallet::DelAddressBook is correctly passing in EncodeDestination(address)

  2. Fix parameter name typo in ErasePurpose walletdb method. 603efe9fc4
  3. meshcollider commented at 11:25 PM on September 26, 2017: contributor

    But the function is called ErasePurpose, it makes sense the argument it is given is called purpose?

  4. PierreRochard commented at 11:29 PM on September 26, 2017: contributor

    @MeshCollider I see where you’re coming from but the method is erasing the purpose by the address key, not the purpose value

  5. meshcollider commented at 11:45 PM on September 26, 2017: contributor

    Oh you're right sorry, yeah. utACK https://github.com/bitcoin/bitcoin/commit/603efe9fc46008c9b7051c8c18d960cfd1e7e0e5

  6. fanquake added the label Wallet on Sep 26, 2017
  7. meshcollider commented at 12:12 AM on September 27, 2017: contributor

    @fanquake I think it should be tagged as refactoring not wallet :)

  8. donaloconnor commented at 8:24 AM on September 27, 2017: contributor

    utACK

  9. MarcoFalke added the label Refactoring on Sep 27, 2017
  10. MarcoFalke merged this on Sep 27, 2017
  11. MarcoFalke closed this on Sep 27, 2017
  12. MarcoFalke referenced this in commit 69c7ecef40 on Sep 27, 2017
  13. PierreRochard deleted the branch on Sep 27, 2017
  14. PastaPastaPasta referenced this in commit 02db63df8d on Dec 22, 2019
  15. PastaPastaPasta referenced this in commit 9c8bfe6769 on Jan 2, 2020
  16. PastaPastaPasta referenced this in commit 40d7d6db6e on Jan 4, 2020
  17. PastaPastaPasta referenced this in commit cc46df851c on Jan 4, 2020
  18. PastaPastaPasta referenced this in commit 5a2ba90d55 on Jan 10, 2020
  19. PastaPastaPasta referenced this in commit 1eb6f74684 on Jan 10, 2020
  20. PastaPastaPasta referenced this in commit 07de9ee889 on Jan 10, 2020
  21. PastaPastaPasta referenced this in commit ed9b0e8451 on Jan 12, 2020
  22. ckti referenced this in commit d1bb04a204 on Mar 28, 2021
  23. MarcoFalke locked this on Sep 8, 2021
Contributors
PierreRochardmeshcolliderdonaloconnor
Labels
RefactoringWallet
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me