Startup crash on 0.15.0.1 macOS #11409

<!--- Remove sections that do not apply -->

This issue tracker is only for technical issues related to bitcoin-core.

General bitcoin questions and/or support requests and are best directed to the Bitcoin StackExchange.

For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.

Describe the issue

Crash on startup on 0.15.0.1

Can you reliably reproduce the issue?

Yes

If so, please list the steps to reproduce below:

1. open App
2. app verifies chain
3. app crashes

Expected behaviour

App should not crash

Actual behaviour

App crashes

Screenshots.

n/a

What version of bitcoin-core are you using?

0.15.0.1 Distibution

Machine specs:

• OS: macOS 10.13 (17A362a)
• CPU: 2.9 GHz Intel Core i7
• RAM: 16 GB 2133 MHz LPDDR3
• Disk size: 1T
• Disk Type (HD/SDD): SDD

Any extra information that might be useful in the debugging process.

This is normally the contents of a debug.log or config.log file. Raw text or a link to a pastebin type site are preferred.

Process:               Bitcoin-Qt [1416]
Path:                  /Applications/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
Identifier:            org.bitcoinfoundation.Bitcoin-Qt
Version:               0.15.0 (0.15.0)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Bitcoin-Qt [1416]
User ID:               501

Date/Time:             2017-09-27 10:06:14.239 -0400
OS Version:            Mac OS X 10.13 (17A362a)
Report Version:        12
Bridge OS Version:     3.0 (14Y661)
Anonymous UUID:        DBCBA46A-1D23-05D3-35EB-31ADED1E0B59

Crashed Thread:        10  QThread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Thread 10 Crashed:: QThread
0   libsystem_kernel.dylib        	0x00007fff609a7fce __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff60ae5150 pthread_kill + 333
2   libsystem_c.dylib             	0x00007fff6090432a abort + 127
3   libsystem_c.dylib             	0x00007fff608cc380 __assert_rtn + 320
4   org.bitcoinfoundation.Bitcoin-Qt	0x000000010545e202 0x105308000 + 1401346
5   org.bitcoinfoundation.Bitcoin-Qt	0x000000010545e01e 0x105308000 + 1400862
6   org.bitcoinfoundation.Bitcoin-Qt	0x000000010545c2ef 0x105308000 + 1393391
7   org.bitcoinfoundation.Bitcoin-Qt	0x00000001054d66ba 0x105308000 + 1894074
8   org.bitcoinfoundation.Bitcoin-Qt	0x00000001054dde98 0x105308000 + 1924760
9   org.bitcoinfoundation.Bitcoin-Qt	0x0000000105497372 0x105308000 + 1635186
10  org.bitcoinfoundation.Bitcoin-Qt	0x000000010531da30 0x105308000 + 88624
11  org.bitcoinfoundation.Bitcoin-Qt	0x000000010609ccea 0x105308000 + 14241002
12  org.bitcoinfoundation.Bitcoin-Qt	0x000000010597559e 0x105308000 + 6739358
13  org.bitcoinfoundation.Bitcoin-Qt	0x000000010597725b 0x105308000 + 6746715
14  org.bitcoinfoundation.Bitcoin-Qt	0x00000001060815e4 0x105308000 + 14128612
15  org.bitcoinfoundation.Bitcoin-Qt	0x00000001060822d4 0x105308000 + 14131924
16  org.bitcoinfoundation.Bitcoin-Qt	0x00000001060bbe79 0x105308000 + 14368377
17  org.bitcoinfoundation.Bitcoin-Qt	0x000000010607df31 0x105308000 + 14114609
18  org.bitcoinfoundation.Bitcoin-Qt	0x0000000105f3277e 0x105308000 + 12756862
19  org.bitcoinfoundation.Bitcoin-Qt	0x0000000105f3557a 0x105308000 + 12768634
20  libsystem_pthread.dylib       	0x00007fff60ae26c1 _pthread_body + 340
21  libsystem_pthread.dylib       	0x00007fff60ae256d _pthread_start + 377
22  libsystem_pthread.dylib       	0x00007fff60ae1c5d thread_start + 13

Additional from debug.log

2017-09-27 14:06:13 No coin database inconsistencies in last 7 blocks (15228 transactions)
2017-09-27 14:06:13  block index           11333ms
2017-09-27 14:06:13 init message: Loading wallet...
2017-09-27 14:06:13 nFileVersion = 150001
2017-09-27 14:06:13 Keys: 1006 plaintext, 0 encrypted, 1006 w/ metadata, 1006 total
2017-09-27 14:06:13  wallet                   49ms
2017-09-27 14:06:13 setKeyPool.size() = 1000
2017-09-27 14:06:13 mapWallet.size() = 37
2017-09-27 14:06:13 mapAddressBook.size() = 5
2017-09-27 14:06:13 mapBlockIndex.size() = 487187
2017-09-27 14:06:13 nBestHeight = 487093
2017-09-27 14:06:13 AddLocal([*Redacting local address*]:8333,1)
2017-09-27 14:06:13 torcontrol thread start
2017-09-27 14:06:13 Discover: IPv6 en0: *Redacting address*
2017-09-27 14:06:13 AddLocal([*Redacting local address*]:8333,1)
2017-09-27 14:06:13 Discover: IPv6 en0: *Redacting address*
2017-09-27 14:06:13 Bound to [::]:8333
2017-09-27 14:06:13 Bound to 0.0.0.0:8333
2017-09-27 14:06:13 init message: Loading P2P addresses...
2017-09-27 14:06:14 ERROR: DeserializeDB: Checksum mismatch, data corrupted
2017-09-27 14:06:14 Invalid or missing peers.dat; recreating

Can you run Bitcoin-Qt from a terminal and reproduce the issue? This should provide more info to help debug the issue. ie open Terminal and type /Path/To/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt

Assertion failed: (nIds != nNew), function Serialize, file ./addrman.h, line 320.
Abort trap: 6

ping @instagibbs. I remember in SF you had a corrupt addrdb causing a crash. Do you remember if yours was asserting here as well?

Edit: I remember now, we looked at it. The addrman.Clear() in the case of a load failure isn't enough. Did you look any further into what else needs to be cleared?

@LordAndrei can you upload your peers.dat from your datadir somewhere? It does seem weird that this would cause a crash.

file uploaded to http://s000.tinyupload.com/index.php?file_id=00098316844368004246

@theuni similar assert but I don't think the same one? Can't recall actually.

actually it's the same line: https://github.com/bitcoin/bitcoin/pull/11252

@instagibbs Ah, that explains why I couldn't find anything else to clear! Thanks for fixing. @LordAndrei This will be fixed in an upcoming version. A quick fix for you, if you're still crashing, is to simply delete your peers.dat.

Closing this and marking #11252 for backport.

Tested the attached peers.dat, indeed it fails on 0.15.0.1 and is cleared properly on master.

Removing peers.dat was a good workaround. Muchly appreciated for everyone's help.