Bump univalue subtree and fix json formatting in tests #11420

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1709-bumpUnivalue changing 31 files +851 −297
  1. MarcoFalke commented at 12:41 pm on September 29, 2017: member

    The subtree-merge commit also fixes the whitespace for failing tests, such that bisect doesn’t break.

    Finally, the bump also includes the changes that accidentally modified our subtree, such that the subtree check should work fine now:

    0./contrib/devtools/git-subtree-check.sh src/univalue
    
  2. Squashed 'src/univalue/' changes from 16a1f7f6e..fe805ea74
    fe805ea74 Declare single-argument (non-converting) constructors "explicit"
    8a2d6f1e3 Merge pull request #41 from jgarzik/get-obj-map
    ba341a20d Add getObjMap() helper method.  Also, constify checkObject().
    ceb119413 Handle .pushKV() and .checkObject() edge cases.
    107db9829 Add ::push_back(double) method for feature parity.
    d41530031 Move one-line implementation of UniValue::read() to header.
    52e85b35b Move exception-throwing get_* methods into separate implementation module.
    dac529675 README.md: update code quotes
    3e31dcffb README.md: close code quote
    d09b8429d Update README.md
    f1b86edb4 Convert README to markdown style.
    1dfe464ef Import UniValue class unit tests from bitcoin project.
    0d3e74dd1 operator[] takes size_t index parameter (versus unsigned int)
    640158fa2 Private findKey() method becomes size_t clean, and returns bool on failure.
    709913585 Merge pull request #36 from ryanofsky/pr/end-str
    a31231b51 Version 1.0.3
    4fd5444d1 Reject unterminated strings
    81eba332b Merge pull request #26 from isle2983/pushBackHelpers
    36405413e Merge PR #32 from branch 'nul-not-special' of git://github.com/ryanofsky/univalue into merge
    89bb07322 Merge pull request #31 from ryanofsky/raw-literals
    511008c36 Merge pull request #30 from ryanofsky/test-driver
    77974f3a9 Merge pull request #34 from paveljanik/20161116_Wshadow_codepoint
    a38fcd355 Do not shadow member variable codepoint.
    fd32d1ab8 Don't require nul-terminated string inputs
    0bb1439d0 Support parsing raw literals in UniValue
    28876d045 Merge pull request #29 from btcdrak/exportspace
    839ccd71f Add test driver for JSONTestSuite
    26ef3fff1 Remove trailing whitespace from JSON export
    cfa0384d6 Convenience wrappers for push_back-ing integer types
    REVERT: 16a1f7f6e Merge #3: Pull upstream
    REVERT: daf1285af Merge pull request #2 from jgarzik/master
    REVERT: f32df99e9 Merge branch '2016_04_unicode' into bitcoin
    REVERT: 280b191cb Merge remote-tracking branch 'jgarzik/master' into bitcoin
    REVERT: 2740c4f71 Merge branch '2015_11_escape_plan' into bitcoin
    
    git-subtree-dir: src/univalue
    git-subtree-split: fe805ea74f8919382720b09a905a14e81311b3ad
    619bb05037
  3. Bump univalue and fix json formatting in tests
    This merge commit bumps the univalue subtree and also updates the whitespace
    for some failing tests.
    faaeeb0d3e
  4. MarcoFalke added the label Tests on Sep 29, 2017
  5. MarcoFalke added the label Upstream on Sep 29, 2017
  6. laanwj commented at 12:33 pm on October 4, 2017: member

    utACK faaeeb0

    The whitespace fix is a nice little improvement.

  7. fanquake commented at 1:13 am on October 5, 2017: member
    I haven’t been able to verify this like the secp256k1 subtree. Is this waiting for https://github.com/bitcoin-core/univalue/pull/7 to be merged?
  8. MarcoFalke commented at 7:20 am on October 5, 2017: member
    Jup, the commit should be merged first.
  9. laanwj commented at 10:14 am on October 11, 2017: member
  10. fanquake commented at 11:35 am on October 11, 2017: member

    tested ACK faaeeb0

     0[pull/11420/local-merge f94cd2237] Merge [#11420](/bitcoin-bitcoin/11420/): Bump univalue subtree and fix json formatting in tests
     1 Date: Wed Oct 11 19:13:16 2017 +0800
     2[#11420](/bitcoin-bitcoin/11420/) Bump univalue subtree and fix json formatting in tests into master
     3* faaeeb0d3 Bump univalue and fix json formatting in tests (MarcoFalke) (pull/11420/head)
     4* 619bb0503 Squashed 'src/univalue/' changes from 16a1f7f6e..fe805ea74 (MarcoFalke)
     5
     6Dropping you on a shell so you can try building/testing the merged source.
     7Run 'git diff HEAD~' to show the changes being merged.
     8Type 'exit' when done.
     9bash-3.2$ git fetch https://github.com/bitcoin-core/univalue.git
    10warning: no common commits
    11remote: Counting objects: 565, done.
    12remote: Compressing objects: 100% (7/7), done.
    13remote: Total 565 (delta 0), reused 4 (delta 0), pack-reused 558
    14Receiving objects: 100% (565/565), 111.21 KiB | 77.00 KiB/s, done.
    15Resolving deltas: 100% (304/304), done.
    16From https://github.com/bitcoin-core/univalue
    17 * branch                HEAD       -> FETCH_HEAD
    18bash-3.2$ ./contrib/devtools/git-subtree-check.sh src/univalue
    19src/univalue in HEAD was last updated to upstream commit fe805ea74f8919382720b09a905a14e81311b3ad (tree 5d48005ff778ddf521705b5d08d19189966fc36b)
    20src/univalue in HEAD currently refers to tree 5d48005ff778ddf521705b5d08d19189966fc36b
    21GOOD
    
     0/Applications/Xcode.app/Contents/Developer/usr/bin/make  check-TESTS check-local
     1Running test/util/bitcoin-util-test.py...
     2/usr/local/bin/python3.6 ../test/util/bitcoin-util-test.py
     3  CC       src/tests-tests.o
     4  CC       src/exhaustive_tests-tests_exhaustive.o
     5make[5]: `libsecp256k1.la' is up to date.
     6  CCLD     exhaustive_tests
     7PASS: qt/test/test_bitcoin-qt
     8  CCLD     tests
     9/Applications/Xcode.app/Contents/Developer/usr/bin/make  check-TESTS
    10PASS: exhaustive_tests
    11PASS: tests
    12============================================================================
    13Testsuite summary for libsecp256k1 0.1
    14============================================================================
    15# TOTAL: 2
    16# PASS:  2
    17# SKIP:  0
    18# XFAIL: 0
    19# FAIL:  0
    20# XPASS: 0
    21# ERROR: 0
    22============================================================================
    23  CXX      test/test_object-object.o
    24  CXX      test/test_test_json-test_json.o
    25  CXX      test/test_unitester-unitester.o
    26  CXX      test/test_no_nul-no_nul.o
    27  CXXLD    test/no_nul
    28  CXXLD    test/test_json
    29  CXXLD    test/unitester
    30  CXXLD    test/object
    31/Applications/Xcode.app/Contents/Developer/usr/bin/make  check-TESTS
    32PASS: test/no_nul
    33PASS: test/object
    34PASS: test/unitester
    35============================================================================
    36Testsuite summary for univalue 1.0.3
    37============================================================================
    38# TOTAL: 3
    39# PASS:  3
    40# SKIP:  0
    41# XFAIL: 0
    42# FAIL:  0
    43# XPASS: 0
    44# ERROR: 0
    45============================================================================
    46PASS: test/test_bitcoin
    47============================================================================
    48Testsuite summary for Bitcoin Core 0.15.99
    49============================================================================
    50# TOTAL: 2
    51# PASS:  2
    52# SKIP:  0
    53# XFAIL: 0
    54# FAIL:  0
    55# XPASS: 0
    56# ERROR: 0
    57============================================================================
    58Making check in doc/man
    59make[1]: Nothing to be done for `check'.
    60make[1]: Nothing to be done for `check-am'.
    
  11. laanwj commented at 4:14 pm on October 11, 2017: member

    Thanks for testing @fanquake , looks good to me now.

    Edit: I got a lot of linker errors when building this. Re-trying after cleaning my tree. Yes, that fixed it.

  12. laanwj merged this on Oct 11, 2017
  13. laanwj closed this on Oct 11, 2017

  14. laanwj referenced this in commit 892809309c on Oct 11, 2017
  15. MarcoFalke deleted the branch on Nov 10, 2017
  16. laanwj referenced this in commit d4e404a3af on Dec 20, 2017
  17. sickpig referenced this in commit 817813397c on Jan 10, 2018
  18. protonn referenced this in commit 1a4e549f0b on Mar 4, 2018
  19. virtload referenced this in commit 8067acb367 on Apr 4, 2018
  20. jasonbcox referenced this in commit b7f2d9a123 on Jul 25, 2019
  21. PastaPastaPasta referenced this in commit 48f0ceee99 on Dec 22, 2019
  22. PastaPastaPasta referenced this in commit be10f9e28c on Jan 2, 2020
  23. PastaPastaPasta referenced this in commit eee873a934 on Jan 4, 2020
  24. PastaPastaPasta referenced this in commit 7d7fc8c5f0 on Jan 12, 2020
  25. PastaPastaPasta referenced this in commit 6a8675c97c on Jan 12, 2020
  26. PastaPastaPasta referenced this in commit f0961ef655 on Jan 12, 2020
  27. PastaPastaPasta referenced this in commit 18836569f0 on Jan 12, 2020
  28. PastaPastaPasta referenced this in commit 1718977d47 on Jan 12, 2020
  29. PastaPastaPasta referenced this in commit cc40200bea on Jan 12, 2020
  30. PastaPastaPasta referenced this in commit 36bb302f80 on Jan 12, 2020
  31. PastaPastaPasta referenced this in commit b53223581d on Jan 17, 2020
  32. PastaPastaPasta referenced this in commit 690189b9d2 on Jan 22, 2020
  33. PastaPastaPasta referenced this in commit 332b024009 on Jan 22, 2020
  34. PastaPastaPasta referenced this in commit d49f484027 on Jan 29, 2020
  35. PastaPastaPasta referenced this in commit e5a8e6f4ea on Jan 29, 2020
  36. PastaPastaPasta referenced this in commit f5ea528ecc on Jan 29, 2020
  37. PastaPastaPasta referenced this in commit 3654f15c91 on Jan 31, 2020
  38. ckti referenced this in commit 2dc2e5222a on Mar 28, 2021
  39. ckti referenced this in commit 735b2f2543 on Mar 28, 2021
  40. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me