The LevelDB docs seem to indicate that an iterator will not take snapshots (even providing instructions on how to do so yourself). In several of the places we use them, we assume snapshots to have been taken.
In order to make sure LevelDB doesn't change out from under us (and to prevent the next person who reads the docs from having the same fright I did), verify that snapshots are taken in our tests.
203 | @@ -204,19 +204,33 @@ BOOST_AUTO_TEST_CASE(iterator_ordering) 204 | for (int x=0x00; x<256; ++x) { 205 | uint8_t key = x; 206 | uint32_t value = x*x; 207 | - BOOST_CHECK(dbw.Write(key, value)); 208 | + if (!(x & 1))
Can I haz braces before indenting?
No, but I fixed it anyway :p.
utACK
The LevelDB docs seem to indicate that an iterator will not take
snapshots (even providing instructions on how to do so yourself).
In several of the places we use them, we assume snapshots to have
been taken.
In order to make sure LevelDB doesn't change out from under us
(and to prevent the next person who reads the docs from having the
same fright I did), verify that snapshots are taken in our tests.
Yes, iterators not changing under us is an important part of our leveldb usage. I remember in the past this was well-documented. I wonder when they changed the documentation to no longer say this, and what their plans here are?
In any case it's good to check. utACK bb8376b