Add BIP16 to consensus params for consistency #11430

pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:b16-bip90-bip16 changing 3 files +8 −5

jtimon commented at 5:20 PM on September 30, 2017: contributor

Not only regtest could activate bip16 earlier than 1333238400 (aka Apr 1 2012), but also altchains rebasing on top of bitcoin core could activate it from the beginning of time (aka time 0, long before 1970's epoch and height=0 because bip16 was faulty in using time instead of height, but it is fine to "abuse" uint32_t for 2 purposes here).

~~Depencies:~~

~~- [ ] BIP90: Make buried deployments slightly more easily extensible #11426~~
jtimon renamed this:
~~B16 bip90 bip16~~
BIP90: Add BIP16 to buried_deployments for consistency
on Sep 30, 2017
jtimon force-pushed on Sep 30, 2017
fanquake added the label Consensus on Oct 1, 2017

in src/consensus/params.h:60 in d75692cecb outdated

  61 |       * (nPowTargetTimespan / nPowTargetSpacing) which is also used for BIP9 deployments.
  62 |       * Examples: 1916 for 95%, 1512 for testchains.
  63 |       */
  64 |      uint32_t nRuleChangeActivationThreshold;
  65 |      uint32_t nMinerConfirmationWindow;
  66 | +    /** BIP90: Block height at which buried deployments becomes active */

ryanofsky commented at 3:15 PM on October 2, 2017:

Comment is misleading because because the BIP16 value is not a block height. Should clarify the comment, or maybe change the type of the array.

ryanofsky commented at 3:17 PM on October 2, 2017: member

utACK d75692cecba1e834c598734703a5634549f19159 as long as misleading comment about block heights is fixed.
ryanofsky referenced this in commit 2649d1690c on Oct 2, 2017
jtimon force-pushed on Oct 15, 2017
jtimon renamed this:
~~BIP90: Add BIP16 to buried_deployments for consistency~~
Add BIP16 to consensus params for consistency
on Oct 15, 2017
jtimon commented at 3:02 PM on October 15, 2017: contributor

Decoupled from #11426 (solves @ryanofsky 's nit).
Add BIP16 to consensus params for consistency 21083c7a67
jtimon force-pushed on Oct 15, 2017
ryanofsky commented at 1:32 PM on October 16, 2017: member

utACK 21083c7a6738fb9661577dff0b1a611759bb1d32.

Seems fine, but sipa has a pr which activates it based on height instead of time: https://github.com/bitcoin/bitcoin/pull/11389
jtimon commented at 7:05 PM on November 2, 2017: contributor

Closing in favor of #11389
jtimon closed this on Nov 2, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

jtimon

ryanofsky

Labels

Consensus

Linked (view graph)

#11426 BIP90: Make buried deployments slightly more easily extensible