Addresses issue #11462 by updating the documentation for the importprivkey arguments to the correct names, and updates the functional test importprunedfunds.py to use named arguments when calling importprivkey.
rpc: Update named args documentation for importprivkey #11465
pull dusty-wil wants to merge 1 commits into bitcoin:master from dusty-wil:master changing 2 files +3 −3-
dusty-wil commented at 3:31 AM on October 9, 2017: contributor
- fanquake added the label RPC/REST/ZMQ on Oct 9, 2017
-
promag commented at 8:44 AM on October 9, 2017: member
IMO remove 2nd commit.
-
MarcoFalke commented at 8:56 AM on October 9, 2017: member
why?
Could squash, though.
https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
-
MarcoFalke commented at 8:59 AM on October 9, 2017: member
@promag It nicely proves that the documentation now matches the named args
-
promag commented at 9:01 AM on October 9, 2017: member
The first commit does what the PR title states. No need to change the test to use named arguments. This is obviously my opinion!
-
promag commented at 9:02 AM on October 9, 2017: member
No, the test does not prove that, to prove that we should assert the documentation string.
Again consider my comment above a nit.
-
promag commented at 9:04 AM on October 9, 2017: member
There must be a test to assert argument order too :) (although that is probably in other tests).
-
dusty-wil commented at 10:54 AM on October 9, 2017: contributor
@MarcoFalke @promag I can remove the second commit if you'd prefer! Is there a neat way to do that through github or do I need to re-commit with the changes?
-
promag commented at 11:15 AM on October 9, 2017: member
For reference, this was missed in #8811 (9adb4e1). @dusty-wil to remove the commit you must push again. But do not remove it now, wait for more comments.
-
MarcoFalke commented at 11:23 AM on October 9, 2017: member
I think squashing makes the most sense. See here: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
-
aa57590d7c
Update importprivkey named args documentation
Fixes #11462. Updated documentation for importprivkey function to use the correct name for the first argument. Also updates a call to importprivkey to use named args in functional test.
- dusty-wil force-pushed on Oct 9, 2017
-
dusty-wil commented at 11:45 AM on October 9, 2017: contributor
@MarcoFalke ok, squashed!
-
laanwj commented at 1:17 PM on October 9, 2017: member
-
fanquake commented at 1:40 PM on October 9, 2017: member
utACK aa57590
-
MarcoFalke commented at 4:25 PM on October 9, 2017: member
utACK aa57590
- MarcoFalke merged this on Oct 9, 2017
- MarcoFalke closed this on Oct 9, 2017
- MarcoFalke referenced this in commit 92eadc3950 on Oct 9, 2017
-
dusty-wil commented at 5:16 PM on October 9, 2017: contributor
Thanks for the opportunity to contribute!
- MarcoFalke referenced this in commit 405e069d3b on Oct 9, 2017
- codablock referenced this in commit f8f55c25c8 on Sep 25, 2019
- barrystyle referenced this in commit 90eaca8ada on Jan 22, 2020
- DrahtBot locked this on Sep 8, 2021
