Remove comment and use log statement instead of it.
This log statement wouldn't be executed many times and hence it wouldn't flood the log. On the other side, it is very expressive and would increase the usefulness of the log.
Net: Log when peer reached MAX_BLOCKS_IN_TRANSIT_PER_PEER #11510
pull simonmulser wants to merge 1 commits into bitcoin:master from simonmulser:add_log changing 1 files +2 −1-
simonmulser commented at 9:26 AM on October 16, 2017: none
-
log when peer reached MAX_BLOCKS_IN_TRANSIT_PER_PEER 6898ba98f9
- simonmulser force-pushed on Oct 16, 2017
- fanquake added the label Docs and Output on Oct 16, 2017
-
TheBlueMatt commented at 2:31 PM on October 17, 2017: member
I assume this may result in lots of needless printing in response to headers messages during IBD after we reach the minimum chain work point? Also, we usually only use the term "trivial" to refer to PRs which do not change any code and only change either strings or comments.
- simonmulser renamed this:
Trivial: Log when peer reached MAX_BLOCKS_IN_TRANSIT_PER_PEER
Net: Log when peer reached MAX_BLOCKS_IN_TRANSIT_PER_PEER
on Oct 17, 2017 -
simonmulser commented at 2:54 PM on October 17, 2017: none
Didn't thought about the IBD. Will close the PR.
- simonmulser closed this on Oct 17, 2017
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels