Add share/rpcuser to dist. source code archive #11530

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1710-distShare changing 1 files +4 −1
  1. MarcoFalke commented at 8:21 pm on October 19, 2017: member

    As the legacy rpcuser and rpcpassword are deprected since 0.12.0, we should actually include the script to generate the new auth pair in the distributed source code archive.

    Ref: #6753

    (Tagging for backport, since it is a trivial bugfix)

  2. Add share/rpcuser to dist. source code archive fa81534d06
  3. MarcoFalke added the label Build system on Oct 19, 2017
  4. MarcoFalke added this to the milestone 0.15.1 on Oct 19, 2017
  5. MarcoFalke added the label Needs backport on Oct 19, 2017
  6. laanwj commented at 7:16 am on October 21, 2017: member

    This is certainly a step forward, but if we expect everyone to use it, shouldn’t we include it in binary distributions as well - or even just install it as a command in make install?

    (I’m ambivalent on removing rpcuser/rpcpassword btw, I think they’re useful enough to keep around for simple and quick authentication configuration, but that discussion doesn’t need to be here)

  7. ryanofsky commented at 3:44 pm on October 24, 2017: member

    utACK fa81534d068cb5479684ed9fb073dc51532b91ca

    Agree with laanw that it probably also does make sense to install, too. But that change will require this one.

  8. laanwj commented at 2:55 pm on October 26, 2017: member
    Yes, this is a step forward in any case… utACK
  9. laanwj merged this on Oct 26, 2017
  10. laanwj closed this on Oct 26, 2017

  11. laanwj referenced this in commit cf8c4a7633 on Oct 26, 2017
  12. laanwj referenced this in commit 265bb214ec on Oct 26, 2017
  13. laanwj removed the label Needs backport on Oct 26, 2017
  14. NicolasDorier commented at 3:43 pm on October 26, 2017: contributor
    Please do not remove user/pwd until bitcoin-cli can generate the creds. Having to install python just for generating credentials is a PITA, probably the main reason why people are still using usr/pwd.
  15. MarcoFalke deleted the branch on Oct 26, 2017
  16. MarcoFalke commented at 6:17 pm on October 26, 2017: member
    @NicolasDorier No worries. No one created a pull for it, so I don’t think that will happen any time soon.
  17. codablock referenced this in commit 07d895e1ca on Sep 26, 2019
  18. codablock referenced this in commit c6c337152f on Sep 30, 2019
  19. barrystyle referenced this in commit 59e55d3bb1 on Jan 22, 2020
  20. laanwj referenced this in commit baa72cd9a2 on Mar 25, 2020
  21. sidhujag referenced this in commit 56ca0913fc on Mar 28, 2020
  22. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me