freebsd 11.1 g++7 build #11542

pull lyrra wants to merge 1 commits into bitcoin:master from lyrra:freebsd-11 changing 1 files +3 −5

lyrra commented at 7:08 AM on October 21, 2017: none

build for freebsd 11.1 g++7 (really moving to g++ std11)
freebsd 11.1 g++7 build 11abbbffe1

in src/bitcoin-tx.cpp:251 in 11abbbffe1

 247 | @@ -250,7 +248,7 @@ static void MutateTxAddInput(CMutableTransaction& tx, const std::string& strInpu
 248 |      // extract the optional sequence number
 249 |      uint32_t nSequenceIn=std::numeric_limits<unsigned int>::max();
 250 |      if (vStrInputParts.size() > 2)
 251 | -        nSequenceIn = std::stoul(vStrInputParts[2]);
 252 | +        nSequenceIn = stoul(vStrInputParts[2], 0, 10);

laanwj commented at 7:14 AM on October 21, 2017:

Please keep using the fully-qualified name

fanquake added the label Linux/Unix on Oct 21, 2017
laanwj commented at 7:19 AM on October 21, 2017: member

Did anything change in the C++ standard to require explicitly passing these arguments instead of implicitly by default? (or is this just a workaround for a broken compiler?)
in src/bitcoin-tx.cpp:26 in 11abbbffe1
```
  21 | @@ -22,8 +22,6 @@
  22 |  #include "utilmoneystr.h"
  23 |  #include "utilstrencodings.h"
  24 |  
  25 | -#include <stdio.h>
  26 | -
```
paveljanik commented at 8:12 AM on October 21, 2017:

I think that this is the only valid change right now. ... But as we use fprintf to stderr for printing error messages...
lyrra commented at 8:45 AM on October 21, 2017: none

Please wait, I'll gmake clean && gmake without the patch :)
lyrra commented at 11:51 AM on October 21, 2017: none

Please disregard my patch! I have now compiled&installed&runned bitcoind with both Clang and g++7. My patch sprung from trying to fix build on an older freebsd with older compiler and boost (pre-c++11).
fanquake commented at 12:45 AM on October 22, 2017: member

Thanks @lyrra, I'll close this PR then.
fanquake closed this on Oct 22, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels