[P2P] Throw Warning if -peerbloomfilters is enabled #11553

Issue: #9540

In line with previous threads about the risks os BIP37 peer bloom filters, throw a warning if the peerbloomfilters flag is enabled (which it is by default right now).

If we are going to warn for this, then the default should be false, not true. However changing that may cause severe disruption to the network because many lightweight wallets use BIP 37. Until there is a suitable alternative to BIP 37 (e.g. client side filtering) that is widely deployed, I don't think this is appropriate.

NACK

Agree with @achow101 - until there is a suitable alternative widely available, NACK.

On October 24, 2017 1:51:28 PM EDT, Andrew Chow notifications@github.com wrote:

If we are going to warn for this, then the default should be false, not true. However changing that may cause severe disruption to the network because many lightweight wallets use BIP 37. Until there is a suitable alternative to BIP 37 (e.g. client side filtering), I don't think this is appropriate.

NACK

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/bitcoin/bitcoin/pull/11553#issuecomment-339075580

@achow101 @TheBlueMatt thanks for reviewing the PR. As discussed on IRC and rightly pointed out here, the issue is quite a sensitive topic and the better option would be to wait for a alternative to BIP37. Closing this PR.