[Util] Update tinyformat.h #11573

1. 
   fanquake commented at 3:23 AM on October 29, 2017: member

   Updates tinyformat.h to commit c42f/tinyformat@689695c upstream. Including: https://github.com/c42f/tinyformat/commit/8a2812d8480bfb66923eea0bb5cdda79fe4f17ba https://github.com/c42f/tinyformat/commit/5d9e05a3479d1b2ec6a4602fd797f0ec26440db2 https://github.com/c42f/tinyformat/commit/48e2e48789907f80a7aec24a3f1d69196b78ed43 @achow101 mentioned that since upgrading to Ubuntu 17.10 (GCC 7), tinyformat had been throwing lots of -Wimplicit-fallthrough warnings. However fallthrough warnings should have been silenced by #10489. cc @theuni.

   The upstream commit to fix fallthrough warnings is in this PR https://github.com/c42f/tinyformat/pull/39.

   The last time tinyformat.h was updated in this repo was in #8274.

2. fanquake added the label Utils and libraries on Oct 29, 2017
3. fanquake requested review from laanwj on Oct 29, 2017
4. fanquake requested review from achow101 on Oct 29, 2017
5. in src/tinyformat.h:499 in 65aae56432 outdated

    494 | @@ -495,7 +495,11 @@ namespace detail {
    495 |  class FormatArg
    496 |  {
    497 |      public:
    498 | -        FormatArg() {}
    499 | +        FormatArg()
    500 | +             : m_value(NULL),
   

   ---

   ---

   

   achow101 commented at 3:35 AM on October 29, 2017:

   Should this be NULL or nullptr? IIRC we prefer to use nullptr instead of NULL and tinyformat is something that we have made our own changes to before.

   ---

   

   fanquake commented at 3:43 AM on October 29, 2017:

   In https://github.com/c42f/tinyformat/pull/43 it was originally nullptr, then changed to NULL. However if nullptr is preferred we'll use that, as we are already maintaining our own changes to this code.

   ---

   

   unknown commented at 11:25 AM on October 29, 2017:

   In the Developer Notes is written "nullptr is preferred over NULL or (void*)0."

   ---

   

   fanquake commented at 1:13 PM on October 29, 2017:

   Updated to use nullptr.

6. 
   achow101 commented at 3:41 AM on October 29, 2017: member

   This does indeed silence the -Wimplicit-fallthrough warnings

7. [Util] Update tinyformat.h

   Updates `tinyformat.h` to commit c42f/tinyformat@689695c upstream.

   60b98f8e14
8. fanquake force-pushed on Oct 29, 2017
9. 
   achow101 commented at 3:47 PM on October 29, 2017: member

   Tested ACK 60b98f8e145617e9e50a2eb7f3181953e1e8c424

10. 
    laanwj commented at 1:07 PM on November 1, 2017: member

    utACK 60b98f8e145617e9e50a2eb7f3181953e1e8c424

11. laanwj merged this on Nov 1, 2017
12. laanwj closed this on Nov 1, 2017

    ---

13. laanwj referenced this in commit 2631d55f61 on Nov 1, 2017
14. sickpig referenced this in commit a5093ead3d on Jan 11, 2018
15. sickpig referenced this in commit 47ba4dac33 on Jan 11, 2018
16. jasonbcox referenced this in commit 87684f13e3 on Aug 16, 2019
17. jonspock referenced this in commit c5b0ff083c on Nov 4, 2019
18. proteanx referenced this in commit 386c05eff9 on Nov 4, 2019
19. PastaPastaPasta referenced this in commit 31ef3121fd on Dec 22, 2019
20. PastaPastaPasta referenced this in commit a15f9b9b7d on Jan 2, 2020
21. PastaPastaPasta referenced this in commit ba471b6e03 on Jan 4, 2020
22. PastaPastaPasta referenced this in commit 50c6dc4684 on Jan 12, 2020
23. PastaPastaPasta referenced this in commit 4de44c6f25 on Jan 12, 2020
24. PastaPastaPasta referenced this in commit 59c8d72968 on Jan 12, 2020
25. PastaPastaPasta referenced this in commit 054aac32c3 on Jan 12, 2020
26. PastaPastaPasta referenced this in commit 83a55427a4 on Jan 12, 2020
27. PastaPastaPasta referenced this in commit 30b0a1f9f6 on Jan 12, 2020
28. PastaPastaPasta referenced this in commit 7b26c638c7 on Jan 16, 2020
29. fanquake deleted the branch on Jan 22, 2020
30. ckti referenced this in commit 3d662ac628 on Mar 28, 2021
31. gades referenced this in commit 5314b78a1a on Feb 5, 2022
32. DrahtBot locked this on Feb 15, 2022

Contributors

fanquakeachow101laanwj

Review Requested
laanwj