Make travis complain on #bitcoin-core-dev when builds fail #11598

I suppose this is more of an RFC, but we occasionally have master builds failing and (at least I) dont notice, would be nice to get bugged about it (we already get push notifications, so this shouldn't be too much more volume).

Concept ACK.

I think on_failure should probably be 'change' though. One failure notification is enough, otherwise at times when something is broken beyond our control, the channel spam would get pretty annoying.

AFAIK, this would also do an IRC message if a pull requests would fail? Or only master?

@jonasschnelli docs say "Pull Request builds do not trigger IRC notifications." @theuni I dunno, I kinda like it being annoying, cause it kinda should be.

Open question if travis will complain when a build gets canceled due to a push right afterwards.

Heh, I'm pretty sure this will cause every user to flood bitcoin-core-dev when their private builds fail. @TheBlueMatt for cancel, there are events in the "webhooks" documentation that may work:

    on_success: change # default: always
    on_failure: always # default: always
    on_start: change   # default: never
    on_cancel: always # default: always
    on_error: always # default: always

Concept ACK if limited to master. Not ideal if one can loop a PR push and spam out IRC channel.

@theuni oh, indeed, not sure how to limit it to not include people who have travis turned on on their private forks. Docs dont show anything, oh well.

I dug into this a bit more, but I think Matt is right and IRC notifications can't be conditioned on environment variables (I was hoping we'd be able to condition it on TRAVIS_REPO_SLUG == bitcoin/bitcoin). There's a very old issue to add conditional logic to notifications here: https://github.com/travis-ci/travis-ci/issues/1206. It doesn't look like it'll be implemented any time soon.