[build] Don't fail when passed --disable-lcov and lcov isn't available #11611

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:dontfaillcov changing 1 files +1 −1
  1. fanquake commented at 6:19 AM on November 5, 2017: member

    Fixes #10828 As pointed out in #10828, failing with "lcov not found" when we've been passed --disable-lcov doesn't make sense. Master currently behaves like this (where lcov isn't available):

    ./configure --disable-lcov
    checking for pkg-config... /usr/local/bin/pkg-config
    checking pkg-config is at least version 0.9.0... yes
    configure: error: "lcov testing requested but lcov not found"
    

    cc @janstary

  2. [build] Don't fail when passed --disable-lcov and lcov isn't available 223a4aabd3
  3. fanquake added the label Build system on Nov 5, 2017
  4. fanquake requested review from theuni on Nov 5, 2017
  5. laanwj commented at 5:43 PM on November 5, 2017: member

    utACK

  6. promag commented at 12:03 AM on November 6, 2017: member

    Tested ACK 223a4aa.

  7. laanwj merged this on Nov 6, 2017
  8. laanwj closed this on Nov 6, 2017

  9. laanwj referenced this in commit 0e707919f5 on Nov 6, 2017
  10. PastaPastaPasta referenced this in commit 052b0ed3b7 on Dec 22, 2019
  11. PastaPastaPasta referenced this in commit 017a0fe93d on Jan 2, 2020
  12. PastaPastaPasta referenced this in commit 240c7c860d on Jan 4, 2020
  13. janstary commented at 7:47 PM on January 5, 2020: none

    Saying "lcov testing requested" makes no sense either if the user explicitly said --disable-lconv

  14. PastaPastaPasta referenced this in commit 186855e218 on Jan 12, 2020
  15. PastaPastaPasta referenced this in commit f3eb28a86e on Jan 12, 2020
  16. PastaPastaPasta referenced this in commit db7c195c9e on Jan 12, 2020
  17. PastaPastaPasta referenced this in commit bf5e65b444 on Jan 12, 2020
  18. PastaPastaPasta referenced this in commit ab9f771abc on Jan 12, 2020
  19. PastaPastaPasta referenced this in commit dca599897a on Jan 12, 2020
  20. PastaPastaPasta referenced this in commit bbd89c54f1 on Jan 16, 2020
  21. fanquake deleted the branch on Jan 22, 2020
  22. ckti referenced this in commit e45a774883 on Mar 28, 2021
  23. gades referenced this in commit 059348e7e0 on Jun 26, 2021
  24. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me