Remove unused Boost include. Move Boost include. #11692

pull practicalswift wants to merge 2 commits into bitcoin:master from practicalswift:remove-boost-includes changing 3 files +2 −4

practicalswift commented at 10:11 AM on November 15, 2017: contributor

Remove unused Boost include. Move Boost include.
Remove unused Boost include (boost/thread/thread.hpp) e662f1ba04
Move Boost include (boost/signals2/signal.hpp) to where it is needed 1a30cde4e7
fanquake added the label Refactoring on Nov 15, 2017
in src/rpc/blockchain.cpp:33 in 1a30cde4e7
```
  29 | @@ -30,8 +30,6 @@
  30 |  
  31 |  #include <univalue.h>
  32 |  
  33 | -#include <boost/thread/thread.hpp> // boost::thread::interrupt
```
promag commented at 10:36 AM on November 15, 2017:

Disagree: https://github.com/bitcoin/bitcoin/blob/1a30cde4e7c0f2d78ce5b515d013429961122126/src/rpc/blockchain.cpp#L830

Which uses this header. See http://www.boost.org/doc/libs/1_54_0/doc/html/thread/thread_management.html.
promag commented at 10:38 AM on November 15, 2017: member

Not sure of this kind of PR's. I agree on these changes but in a context.
practicalswift closed this on Nov 15, 2017
practicalswift commented at 11:11 AM on November 15, 2017: contributor

@promag Thanks for the review. I was a bit too quick submitting this PR. I'll close this one!
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels