[trivial] remove trailing whitespace in streams.h #11697

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:streams_trailing_whitespace changing 1 files +1 −1
  1. jnewbery commented at 9:15 PM on November 15, 2017: member

    Removes trailing whitespace added in #11221. I'm not sure how this passed the Travis linter for the PR, but it's causing some of my branches to fail on Travis.

  2. [trivial] remove trailing whitespace in streams.h 81b8d536ee
  3. MarcoFalke commented at 9:28 PM on November 15, 2017: member

    Tend to NACK. Once they failed, they should never fail in the future, since it will only look at the TRAVIS_COMMIT_RANGE. So fixing it here won't really help you.

    I'd rather disable the whitspace check for non-pull_request completely.

  4. jnewbery commented at 10:28 PM on November 15, 2017: member

    Thanks @MarcoFalke - you're right. A better fix is to just disable linters for non-PR travis builds. Once a lint warning is in master it's really too late and we should just move on with our lives :)

    I've opened #11699 for that change.

  5. jnewbery closed this on Nov 15, 2017

  6. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me